[#28379] - [4.0] [mod_tags_popular] Array to string conversion
- Fixed in Code Base
- 17 Mar 2020
- Medium
- Build: 4.0-dev
- # 28379
- Diff
- SharkyKZ:j4/error/mod-tags-popular
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28378.
Summary of Changes
Fixes error in query.
Testing Instructions
Publish Tags - Popular module.
Expected result
Works.
Actual result
Notice: Array to string conversion in modules\mod_tags_popular\src\Helper\TagsPopularHelper.php on line 100
Error: Unknown column 'Array' in 'where clause': Unknown column 'Array' in 'where clause'
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Rel_Number | ⇒ | 28378 | |
| Relation Type | ⇒ | Pull Request for | |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28379.
Please also correct in 3.10
Are you having this issue on 3.10? Looks fine on code review.
In 3.10, the difference is that we have
$groups = implode(',', $user->getAuthorisedViewLevels());
no bindArray
Is that OK?
(I do not have a test site in 3.10 right now.)
That's fine. In 4.0 we're using parameterized queries. That's where the difference came from.
Yup this is fine - only needed in 4.0
can be merged. No use for another test (cs only)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28379.
I have tested this item
i've got the error before applying the pr even without tags
after pr no more errors with and without tags
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28379.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28379.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-17 10:12:17 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
tks
Please also correct in 3.10