Good job! ?

TODO

1. Delete from LanguagesModel the now useless code to create a basic multilingual site as we now do it only via the sampledata plugin.
   This means deleting all from line 565 to 1487

2. Delete from InstallationController
   lines 195 to 204 as we do not use anymore the publishContentLanguages() method

NOTE:
If we want to keep such a method, it should only check for the correct creation of the content language and NOT for its published state. Thus would have to be renamed and string re-added.

3. Delete the ini strings in en-GB and en-US
   INSTL_DEFAULTLANGUAGE_ACTIVATE_MULTILANGUAGE="Activate the multilingual feature"
   INSTL_DEFAULTLANGUAGE_ACTIVATE_MULTILANGUAGE_DESC="If active, your Joomla site will have the multilingual feature active with localised menus for each installed language."
   INSTL_DEFAULTLANGUAGE_ACTIVATE_LANGUAGE_CODE_PLUGIN="Enable the language code plugin"
   INSTL_DEFAULTLANGUAGE_ACTIVATE_LANGUAGE_CODE_PLUGIN_DESC="If enabled, the language code plugin will add the ability to change the language code in the generated HTML document to improve SEO."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_ADD_ASSOCIATIONS="Joomla was unable to automatically create the language associations."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_CONTENT_LANGUAGE="Joomla was unable to automatically create the %s content language."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_MENU="Joomla was unable to automatically create the %s menu."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_MENU_ITEM="Joomla was unable to automatically create the %s home menu item."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_MENU_MODULE="Joomla was unable to automatically create the %s menu module."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_CATEGORY="Joomla was unable to automatically create the %s content category."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_CREATE_ARTICLE="Joomla was unable to automatically create the %s localised article."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_ENABLE_MODULESWHITCHER_LANGUAGECODE="Joomla was unable to automatically publish the language switcher module."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_ENABLE_PLG_LANGUAGECODE="Joomla was unable to automatically enable the Language Code Plugin."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_ENABLE_PLG_LANGUAGEFILTER="Joomla was unable to automatically enable the Language Filter Plugin."
   INSTL_DEFAULTLANGUAGE_MULTILANGUAGE_TITLE="Multilingual"
   INSTL_DEFAULTLANGUAGE_MULTILANGUAGE_DESC="This section allows you to automatically activate the Joomla multilingual feature."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_INSTALL_MULTILANG="Joomla was unable to install the multilingual sample data as only one language is installed. To activate the multilingual feature, you need to install more languages, press the 'Previous' button and choose the desired languages from the list."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_PUBLISH_MOD_MULTILANGSTATUS="Joomla was unable to automatically publish the language status module."
   INSTL_DEFAULTLANGUAGE_COULD_NOT_UNPUBLISH_MOD_DEFAULTMENU="Joomla was unable to automatically unpublish the default menu module."
   INSTL_DEFAULTLANGUAGE_INSTALL_LOCALISED_CONTENT="Install localised content"
   INSTL_DEFAULTLANGUAGE_INSTALL_LOCALISED_CONTENT_DESC="If active, Joomla will automatically create one content category per each installed language. Also, one featured article with dummy content will be created in each category."

4. Normalize en-US for the strings modified

5. Important! Make sure that for a distro which is including already another language than en-GB and therefore that language not needing to be installed, that the list of languages to install does not contain it and that it is presented as possible choice for admin and site default.

@infograf768
1. Delete from LanguagesModel the now useless code to create a basic multilingual site as we now do it only via the sampledata plugin.
This means deleting all from line 565 to 1487

Thank you for your improvements. This is done.

@infograf768
2. Delete from InstallationController
lines 195 to 204 as we do not use anymore the publishContentLanguages() method
NOTE:
If we want to keep such a method, it should only check for the correct creation of the content language and NOT for its published state. Thus would have to be renamed and string re-added.

I deleted these lines because you suggested that. The languages are now unpublished as content languages installed. Is that how it should be?

@infograf768
1. Delete the ini strings in en-GB and en-US
INSTL_DEFAULTLANGUAGE_ACTIVATE_MULTILANGUAGE="Activate the multilingual feature"

Done.

@infograf768
2. Normalize en-US for the strings modified

Done.

@infograf768
Important! Make sure that for a distro which is including already another language
than en-GB and therefore that language not needing to be installed, that the list of languages
to install does not contain it and that it is presented as possible choice for admin and site default.

Since the languages are installed at this point in the installation, that fits. I honestly admit that I haven't tested it.
@tecpromotion Is it possible to test this with the German version?

I deleted these lines because you suggested that. The languages are now unpublished as content languages installed. Is that how it should be?

Yes, it should behave as when we install languages in backend, i.e. the content languages should be created but not be published.
I was not sure ( @Bakual ?) if we should still make sure the Content languages are created, thus my note above.

I would certainly create the content language. I don't mind if they are published or not.

@infograf768 Yes, it should behave as when we install languages in backend, i.e. the content languages should be created but not be published.

This is how it is in this issue at the moment. Then that fits.

If I do not mistake, this PR contains an extraneous file which is a copy of your config.php

@infograf768 If I do not mistake, this PR contains an extraneous file which is a copy of your config.php

Thanks. I deleted this wrong file.

I have tested this item ✅ successfully on cd44169

Works like a charm.

I have not tested this item.

I just saw now the review comment from @infograf768 ?
https://github.com/joomla/joomla-cms/pull/28328/files#r392090741.
@astridx Could you check?

@richard67 @astridx Could you check?

Thanks Richard. I answered it.

@astridx
see my further comment
#28328 (comment)

both work here...

@astridx
Please modify to use InstalledlangsFrontend

The reason is that we do not see an error because the packs we test contain both admin and site parts, but we may have lang packs which contain only the site part, thus why the method/property should correspond precisely.

@infograf768
Sorry, you are right. Done

I have tested this item ✅ successfully on b216ae2

I have tested this item ✅ successfully on b216ae2

I've played around a bit, using skip button, installing a language and setting defaults and then again installing another one and changing default ... all works as one would expect it to work.

Well done.

RTC

Thankyou very much for picking this up @astridx ! Super appreciated and nice work!