Feeling Lucky
?
[#28326] - [4.0] Typo in Installer JavaScript File
- Closed
- 14 Mar 2020
- Medium
- Build: 4.0-dev
- # 28326
- Diff
- astridx:setupjs
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Since the if query checks whether response.error exists, it should also be output. I corrected that.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Installation |
astridx
- comment
- 13 Mar 2020
OK, thank you. But in this case we should check if message exist, right?
if (response.error && response.message) { in line 33.
wilsonge
- comment
- 13 Mar 2020
So if the error property exists and is true there should always be a message property (if you look at the code). So there shouldn't be a need to as long as the code remains as it is.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-14 09:43:51 |
| Closed_By | ⇒ | astridx | |
| Labels |
Added:
?
|
||
This isn't right. error is just a boolean. message contains the actual information to be rendered https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/src/Response/JsonResponse.php#L65