[#28295] - [4.0] Add SVG check for logo
- Fixed in Code Base
- 10 Mar 2020
- Medium
- Build: 4.0-dev
- # 28295
- Diff
- SharkyKZ:j4/js/atum-svg-logo
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28226.
Summary of Changes
Adds file extension check to prevent issues when logo is not SVG.
Testing Instructions
node build.js --compile-js required.
Edit Atum template style.
Select a logo.
Inspect browser console.
Expected result
No errors.
Actual result
XML Parsing Error: not well-formed
Location: http://localhost/joomla-cms/administrator/index.php?option=com_templates&view=style&layout=edit&id=10
Line Number 1, Column 1: index.php:1:1
TypeError: svg is undefined template.js:95:11
Documentation Changes Required
No.
Additional Comments
I've picked what I think is the cleanest approach as it avoids unnecessary request when image is not SVG. It's somewhat limiting (the file doesn't need to have an extension) but works for our case. Alternatively, we could make the request but wrap it in try/catch or try to figure out the response some other way.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Rel_Number | 0 | ⇒ | 28226 |
| Relation Type | ⇒ | Pull Request for |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28295.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28295.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-10 19:24:49 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks.
I have tested this item✅ successfully on 512e9d6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28295.