?
avatar brianteeman
brianteeman
8 Mar 2020

As a quick fix the language folder and files were created in the /api folder

[ ] They appear in discover - nothing on a clean install should be there
[ ] Should they be part of the language package
[ ] How does a language pack install to the api folder

cc @wilsonge

avatar brianteeman brianteeman - open - 8 Mar 2020
avatar joomla-cms-bot joomla-cms-bot - change - 8 Mar 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Mar 2020
avatar wilsonge
wilsonge - comment - 8 Mar 2020

There’s already been PRs for language pack (On phone but will try and dig it out in a bit when home). It depends if you do package installs or all in 1 (both should work).

Yup sounds like it should be added to the pack - I think site and admin are currently separate installs in the package? But whichever way should be treated same as site and admin are now

avatar jwaisner jwaisner - change - 8 Mar 2020
Build staging 4.0-dev
avatar jwaisner jwaisner - change - 8 Mar 2020
Category com_languages Language & Strings Multilanguage
avatar SharkyKZ
SharkyKZ - comment - 9 Mar 2020

I think we just need to add #__extensions entries to installation/update SQL.

avatar Bakual
Bakual - comment - 9 Mar 2020

Yep, admin and site are separate "extensions", usually installed with a package. So the api would ideally be a third extension within that pack. Looking at the files, the needed XMLs are already present.
It needs to be added to the package (https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/manifests/packages/pkg_en-GB.xml) and as @SharkyKZ wrote to the #__extensions

avatar brianteeman
brianteeman - comment - 9 Mar 2020

IF that's the way you want to go forward I can do the PR

avatar Bakual
Bakual - comment - 9 Mar 2020

I haven't thought much about it yet, but I'd say it's the simplest approach. If you can do the PR, that would be appreciated.
Just saw Crowdin needs some adjustment in https://github.com/joomla/joomla-cms/blob/4.0-dev/crowdin.yml as well so it picks up the new XML files.

avatar brianteeman
brianteeman - comment - 9 Mar 2020

are you sure crowdin.yml needs updating? I can see the api on line 15

avatar brianteeman
brianteeman - comment - 9 Mar 2020

PR at #28282

avatar brianteeman brianteeman - change - 9 Mar 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-03-09 10:05:23
Closed_By brianteeman
avatar brianteeman brianteeman - close - 9 Mar 2020
avatar wilsonge
wilsonge - comment - 9 Mar 2020

@brianteeman Crowdin has the ini files but not the xml files

avatar brianteeman
brianteeman - comment - 9 Mar 2020

ah

Add a Comment

Login with GitHub to post a comment