[#28269] - [4.0] loadmodulebyid fix strict comparison
- Closed
- 15 Apr 2020
- Medium
- Build: 4.0-dev
- # 28269
- Diff
- alikon:patch-109
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
cast to int to fix strict comparison
Testing Instructions
create/edit an article
click on CMS Content and select
select a module to embed in the article
save the article
Expected result
the module output is showed in the article
Actual result
no module output
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
why this is wrong ?
umm i was testing with postgresql....i'll look with mysql .....
work with mysql as well
I have tested this item
on code inspect
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269.
I have tested this item
Tested with adding CMS content to article. Content displays correctly after PR is applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269.
No RTC. This breaks PDO.
| Status | Ready to Commit | ⇒ | Pending |
Set back to Pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269.
PDO returns strings for numeric columns when using pdo_mysql.
This seems to be because the driver is using PDO::ATTR_EMULATE_PREPARES.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-15 06:52:45 |
| Closed_By | ⇒ | alikon |
Please test first
#28259