[#28256] - [4.0] Password toggler
- Closed
- 24 Jul 2020
- Very low
- Build: 4.0-dev
- # 28256
Steps to reproduce the issue
Mixing the use of fa-eye and icon-eye in the markup and javascript causes issues
@SharkyKZ some of this comes from a recent pr of yours and I am not sure how to proceed. As it looks like you changed your mind about using icon- or fa- during the pr
Step 1 - page load (com_users)
<span class="fas fa-eye" aria-hidden="true"></span>
Step 2 - after clicking on above
<span class="fas fa-eye icon-eye-close" aria-hidden="true"></span>
Step 3 - after clicking on above
<span class="fas fa-eye icon-eye" aria-hidden="true"></span>
Why does this matter?
The icons/buttons in step 2 & 3 are a different width to step 1
joomla-cms-bot
- | Labels |
Added:
?
|
||
Yes I am confused too
having both classes is wrong.
I've given up on the which iconset classes are better discussion. Right now two are supported. If my work has done anything it's revealed that only a single set should be used. Whether its svg, fa font or icomoon doesn't matter. But it should be singular to stop confusion.
jwaisner
- | Priority | Medium | ⇒ | Very low |
| Status | New | ⇒ | Confirmed |
| Build | staging | ⇒ | 4.0-dev |
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-24 07:30:29 |
| Closed_By | ⇒ | SharkyKZ |
There is still an issue on the login screen - the width changes from 18px to 20px
I kept old classes as advised by you (#27733 (comment)). #27686 converted classes in layouts to FA but forgot to update the JS.
The change is simple to make but to me it's still unclear which classes are to be used.