Conflicting Files ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
6 Mar 2020

Summary of Changes

Some changes to the PHP files for the new webauthn code

Testing Instructions

Same as: #28094

Expected result

WebAuthn still works

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 6 Mar 2020
avatar zero-24 zero-24 - change - 6 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2020
Category Administration Language & Strings Modules Front End com_users Layout Libraries Plugins
avatar zero-24 zero-24 - change - 6 Mar 2020
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 23 Mar 2020

After the last correction about the icon this is ready to get some tests ? also cc'ing @nikosdion as original author in here.

avatar nikosdion
nikosdion - comment - 24 Mar 2020

I have a UX comment.

I very strongly disagree with placing the additional buttons (such as the WebAuthn button) before the form Login button.

The extra buttons are meant for non-password authentication methods, i.e. they are not action buttons to the form nor do they participate in the password login flow like Two Factor Authentication does. Putting them above the Login button has several drawbacks:

  • It makes users falsely believe that they need to enter their username and password to use these login methods. While WebAuthn needs a username (and only a username!) that's just a temporary limitation owning to the current browsers' implementation of WebAuthn.
  • The additional buttons API is open to third parties. One could have other login methods such as login with Facebook, login with Google, login via an SSO server etc. Due to legal reasons they may require a completely different visual language than the rest of the site. For example, Google demands that you use their SVG or PNG for your button. You are not allowed to style your button in any different way. This makes the login form appear wonky.
  • If you are using an SSO you most definitely do not want people to enter their SSO username and password in the form; this is to be handled securely on a separate login server and return a token back to the site. The visual language in this case would not only be misleading but would undermine the security reasons for using an SSO in the first place!
  • I expect that on a typical site you'd end up with login buttons for WebAuthn and one or more of Facebook, Google, Instagram, Twitter, GitHub, Apple or local social networks (e.g. Beidu, VKontakte etc). 2-4 buttons would be the norm, depending on the site's target audience. Pushing the Login button underneath a stack of alternative logins makes the interface puzzling to the user. Why is there a Login button under all these other login buttons? Are the people designing the site drunk? Or am I supposed to fill in my Facebook credentials and click on the Login with Facebook button? Screw it, I don't trust these people, I'll go to another site.

If there's a change you should make it's changing the button label "Login" to "Login with password". I'd propose checking whether there are additional buttons being rendered. If there are, use the "Login with password" label. If there are none, use the "Login" label (since in this context "Login with password" is extraneous and possibly confusing, e.g. "how else would I log in, huh?").

avatar zero-24
zero-24 - comment - 24 Mar 2020

Just to be sure i fully agree with you and it is not my intention to change your inital behavior. Seams i messed around in that file. Will take a closer look to it. Thanks !

avatar zero-24
zero-24 - comment - 24 Mar 2020

Thanks again @nikosdion the mention ordering issue should be solved now. ?

avatar zero-24
zero-24 - comment - 27 Mar 2020

Thanks @Quy ?

avatar Quy
Quy - comment - 30 May 2020

Please fix conflicts.

avatar zero-24 zero-24 - change - 13 Jun 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-06-13 21:53:05
Closed_By zero-24
Labels Added: Conflicting Files
avatar zero-24 zero-24 - close - 13 Jun 2020

Add a Comment

Login with GitHub to post a comment