User tests: Successful: Unsuccessful:
Some changes to the PHP files for the new webauthn code
Same as: #28094
WebAuthn still works
none
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Modules Front End com_users Layout Libraries Plugins |
Labels |
Added:
?
?
|
I have a UX comment.
I very strongly disagree with placing the additional buttons (such as the WebAuthn button) before the form Login button.
The extra buttons are meant for non-password authentication methods, i.e. they are not action buttons to the form nor do they participate in the password login flow like Two Factor Authentication does. Putting them above the Login button has several drawbacks:
If there's a change you should make it's changing the button label "Login" to "Login with password". I'd propose checking whether there are additional buttons being rendered. If there are, use the "Login with password" label. If there are none, use the "Login" label (since in this context "Login with password" is extraneous and possibly confusing, e.g. "how else would I log in, huh?").
Just to be sure i fully agree with you and it is not my intention to change your inital behavior. Seams i messed around in that file. Will take a closer look to it. Thanks !
Thanks again @nikosdion the mention ordering issue should be solved now.
Please fix conflicts.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-06-13 21:53:05 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
Conflicting Files
|
After the last correction about the icon this is ready to get some tests? also cc'ing @nikosdion as original author in here.