[#28248] - [4.0] Fixing searchtools in xtd plugins in frontend (partial fix)
- Fixed in Code Base
- 9 Mar 2020
- Medium
- Build: 4.0-dev
- # 28248
- Diff
- infograf768:4.0_frontend_xtds
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #28119
Summary of Changes
This PR adds searchtools to frontend cassiopea in order to display correctly and use the filters (Filter Options, Clean) when using XTD plugins when editing an article.
It solves correctly the Contact XTD as well as Menu XTD
It also solves tooltips in the search field.
It does NOT solve entirely the issue for Article filters as well as Module filters
This would need a PR by another volunteer to deal with these fields.
Testing Instructions
Edit an article in frontend and use the various XTDs. Try to display or not filters, etc.
Before patch
After patch
Note
I may have added more variables than necessary as well as svg. This can be solved after a next PR which would entirely correct the Article and Module filter fields
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Language & Strings Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.
I also at last found the reason of the broken fields in XTD module frontend.
xml is wrong
patch would be
diff --git a/components/com_modules/forms/filter_modules.xml b/components/com_modules/forms/filter_modules.xml
index 37df5bb..4e0e9bb 100644
--- a/components/com_modules/forms/filter_modules.xml
+++ b/components/com_modules/forms/filter_modules.xml
@@ -1,6 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
-<form>
- <fieldset addfieldpath="/administrator/components/com_modules/models/fields" />
-
+<form addfieldprefix="Joomla\Component\Modules\Administrator\Field">
As soon as this PR is merged, will make a specific PR for that.
don't know why it was changed. RTC again
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.
Note: Changes to filter_articles.xml (frontend) will correct the display of the fields concerned. In next PR.
This does not mean ALL css is corrected/improved (including RTL), but it lets work on these for cassiopea.
don't know why it was changed. RTC again
cause i missed your last sentence
As soon as this PR is merged, will make a specific PR for that.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-09 09:53:10 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@alikon @richard67
First PR ready to test
#28283
I have tested this item✅ successfully on a5898e5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.