[#2821] - Catch the potential DB errors when "#__postinstall_messages" is missing
- Closed
- 24 Jan 2014
- Medium
- Build: master
- # 2821
- Diff
- jms2win:patch-10
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When we proceed with a manual upgrade from Joomla 2.5.17 to J3.2.1 by an unzip of J3.2.1 full package over a current J2.5.17 installation, the #__postinstall_messages is not present and cause the impossibility to login due to the "cPanel" that always abort on DB Error.
The purpose of this fix is to intercept such kind of errors and let the cPanel displayed without any "Post Install Messages".
I have just posted the Bugtracker [#33177] that explains all that with the different steps to reproduce the upgrade of Joomla 3.2.1 on top of 2.5.17 by unzip of 3.2.1 on top of 2.5.17 top procedure
There are several documented methods for upgrading joomla - simply unzipping is not one of them
I have used the Method C that describe the manual upgrade
http://docs.joomla.org/J2.5:Upgrading_from_an_existing_version#Method_C_-_Manual_Upgrade
While I understand the purpose of this, you are completely masking an error here with your solution. If we're really intent on doing this, I would still report the error versus hiding it 100% of the time.
try
{
$messages = $messages_model->getItemList();
}
catch (RuntimeException $e)
{
$messages = array();
// Still render the error message from the Exception object
JFactory::getApplication()->enqueueMessage($e->getMessage(), 'error');
}
Yes this is a good idea to also displaying the error message to the user.
This will alerts him that something is wrong in the DB and that he has to fix the DB.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-01-24 13:31:31 |
As thats not the correct way to perform an update I fail to see the purpose of this