?

User tests: Successful: Unsuccessful:

avatar jms2win
jms2win
21 Jan 2014

It may happen that an error is resulting of a DB Error.
In this case the $error can be a "RuntimeException" object that does not contain the "get" function.

This fix allow verifying that the $error has a "get" method and avoid a PHP Fatal error that forbid to report the real DB error.

avatar jms2win jms2win - open - 21 Jan 2014
avatar Bakual
Bakual - comment - 21 Jan 2014

Thanks for your PR. Can you create a tracker item on Joomlacode (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103) and reference it back here?

Also make sure to add some testing instructions of your patch.

avatar jms2win
jms2win - comment - 21 Jan 2014

I have just posted the Bugtracker [#33177] that explains all that with the different steps to reproduce the upgrade of Joomla 3.2.1 on top of 2.5.17 by unzip of 3.2.1 on top of 2.5.17 top procedure

avatar brianteeman
brianteeman - comment - 22 Jan 2014

Again this is because you are upgrading joomla the wrong way. There are several documented methods for doing this and unzipping over the top is not one of them.

avatar jms2win
jms2win - comment - 22 Jan 2014

I have used the Method C "Manual Upgrade" that consists in the unzip on top of the previous version.
http://docs.joomla.org/J2.5:Upgrading_from_an_existing_version#Method_C_-_Manual_Upgrade

avatar mbabker mbabker - reference | - 19 Feb 14
avatar mbabker
mbabker - comment - 19 Feb 2014

Closing, fixed with just using getCode() at 805b092 (since it is already used a few lines above). This is also consistent with the current use in 3.2.

avatar mbabker mbabker - close - 19 Feb 2014

Add a Comment

Login with GitHub to post a comment