User tests: Successful: Unsuccessful:
It may happen that an error is resulting of a DB Error.
In this case the $error can be a "RuntimeException" object that does not contain the "get" function.
This fix allow verifying that the $error has a "get" method and avoid a PHP Fatal error that forbid to report the real DB error.
I have just posted the Bugtracker [#33177] that explains all that with the different steps to reproduce the upgrade of Joomla 3.2.1 on top of 2.5.17 by unzip of 3.2.1 on top of 2.5.17 top procedure
Again this is because you are upgrading joomla the wrong way. There are several documented methods for doing this and unzipping over the top is not one of them.
I have used the Method C "Manual Upgrade" that consists in the unzip on top of the previous version.
http://docs.joomla.org/J2.5:Upgrading_from_an_existing_version#Method_C_-_Manual_Upgrade
Thanks for your PR. Can you create a tracker item on Joomlacode (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103) and reference it back here?
Also make sure to add some testing instructions of your patch.