Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#28186] - [4.0] Use variables for Bootstrap badges

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
2 Mar 2020

Partial Pull Request for Issue #26052 .

Summary of Changes

Cleans up badge SCSS a little.
Also removes unused badge-inverse class.

Testing Instructions

Look at some badges (e.g. Post Installation Messages in the header).

Expected result

Looks the same.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 2 Mar 2020
avatar SharkyKZ SharkyKZ - change - 2 Mar 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2020
Category ⇒ Modules Administration Templates (admin) Front End
avatar Quy
Quy - comment - 2 Mar 2020

I have tested this item ✅ successfully on de9d7a6

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28186.

avatar Quy Quy - test_item - 2 Mar 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 2 Mar 2020

badge-pill is also used in
modules\mod_stats\tmpl\default.php and
build\media_source\com_cpanel\js\admin-system-loader.es6.js

avatar SharkyKZ SharkyKZ - change - 2 Mar 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2020
Category Modules Administration Templates (admin) Front End ⇒ Modules Administration Templates (admin) JavaScript Repository NPM Change Front End
avatar SharkyKZ
SharkyKZ - comment - 2 Mar 2020

Removed from admin-system-loader.es6.js. Don't see it in mod_stats. And this is for backend template only.

avatar brianteeman
brianteeman - comment - 2 Mar 2020

joomla-cms/modules/mod_stats/tmpl/default.php

Line 16 in bf7782e

<span class="badge badge-secondary badge-pill"><?php echo $item->data; ?></span>

but fare comment about this being an admin only pr

avatar SharkyKZ
SharkyKZ - comment - 2 Mar 2020

Derp. I did remove it in first commit (de9d7a6#diff-ea6dc2def3568a4d1c41eef8a1b08288).

avatar SharkyKZ SharkyKZ - change - 2 Mar 2020
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2020
Category Modules Administration Templates (admin) Front End JavaScript Repository NPM Change ⇒ Modules Administration Templates (admin) JavaScript Repository NPM Change
avatar infograf768 infograf768 - test_item - 3 Mar 2020 - Not tested
avatar infograf768
infograf768 - comment - 3 Mar 2020

I have tested this item ✅ successfully on a01bc62

Looks fine here.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28186.

avatar infograf768 infograf768 - test_item - 3 Mar 2020 - Tested successfully
avatar Quy
Quy - comment - 3 Mar 2020

I have tested this item ✅ successfully on a01bc62

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28186.

avatar Quy Quy - test_item - 3 Mar 2020 - Tested successfully
avatar Quy Quy - change - 3 Mar 2020
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 3 Mar 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28186.

avatar Quy
Quy - comment - 3 Mar 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28186.

avatar infograf768
infograf768 - comment - 4 Mar 2020

@wilsonge
Can be merged. Drone failure is unrelated.

avatar rdeutz rdeutz - change - 4 Mar 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-03-04 09:08:09
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 4 Mar 2020
avatar rdeutz rdeutz - merge - 4 Mar 2020

Add a Comment

Login with GitHub to post a comment