Feeling Lucky
?
?
[#28179] - [4.0] Improve cache check
- Fixed in Code Base
- 1 Mar 2020
- Medium
- Build: 4.0-dev
- # 28179
- Diff
- wilsonge:fix/active-tab-check
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes the cache check to always use the active class in PHP instead of a hardcoded value. We set the value using the __METHOD__ value two lines above but then hardcode the check here. This makes the class "dynamic" as per best practice in anticipation of namespacing at a soon to be point in time.
Testing Instructions
Code review
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
ChristineWk
- comment
- 1 Mar 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28179.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
SharkyKZ
- comment
- 1 Mar 2020
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28179.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-01 22:02:50 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 1 Mar 2020
Thanks guys!
I have tested this item✅ successfully on a20d137
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28179.