? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
1 Mar 2020

When I wrote #19353, I apparently forgot to take care of the discovering path.

Summary of Changes

This PR adds support for the new langmetadata.xml to the discovering methods so an already present language may be discovered and installed.

Testing Instructions

Install a language which doesn't use the prefixes anymore. For that you have to manually fetch the language pack from Crowdin. A good language to test is usually Dutch (https://crowdin.com/backend/download/project/joomla-cms/nl.zip) or Danish (https://crowdin.com/backend/download/project/joomla-cms/da.zip) as they are usually 100% translated and approved (or close to). You can try to install the downloaded zip directly. If it fails, you need to extract the zip and only zip the 4.0-dev folder again. Then use that zipped 4.0-dev file.

After that, you need to delete the entries in the database table #__extensions for that language

Then go to the discover extension view and check if the language appears.

Expected result

Language appears twice, once for Site and for Admin.
Language can be installed.

Actual result

Language doesn't appear.

Documentation Changes Required

None

avatar Bakual Bakual - open - 1 Mar 2020
avatar Bakual Bakual - change - 1 Mar 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2020
Category Libraries
avatar Bakual
Bakual - comment - 1 Mar 2020

Hmm, just noticed the same error also exists in J3.10 since the original PR was done against this version. So this needs to be backported. However it will be harder to test there since no such language packs exists for 3.10. They likely all will have prefixed files.

avatar wilsonge
wilsonge - comment - 1 Mar 2020

Make the back port PR too once this is merged. @zero-24 you'll probably need to do that on code review based on the changes here.

avatar Bakual
Bakual - comment - 1 Mar 2020

Backport PR: #28180

avatar infograf768
infograf768 - comment - 2 Mar 2020

I have tested this item successfully on b1ec477


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28178.

avatar infograf768 infograf768 - test_item - 2 Mar 2020 - Tested successfully
avatar blueforce
blueforce - comment - 3 Mar 2020

I have tested this item successfully on b1ec477


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28178.

avatar blueforce blueforce - test_item - 3 Mar 2020 - Tested successfully
avatar infograf768 infograf768 - change - 3 Mar 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 3 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28178.

avatar infograf768 infograf768 - change - 3 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-03 07:59:39
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 3 Mar 2020
avatar infograf768 infograf768 - merge - 3 Mar 2020
avatar infograf768
infograf768 - comment - 3 Mar 2020

tks

Add a Comment

Login with GitHub to post a comment