[#28088] - [4.0] helpsite removal
- Fixed in Code Base
- 2 Mar 2020
- Medium
- Build: 4.0-dev
- # 28088
- Diff
- brianteeman:is_it_friday_yet_2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Removes the remaining parts of the helpsite code that was removed in 3.9. due to file renaming these were missed.
code review
discovered by finally having the lint running
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings Templates (admin) JavaScript Repository NPM Change Libraries |
No that is used by the help button
Deleted the file without affecting the Help button. The value is obtained from the configuration file.
public $helpurl = 'https://help.joomla.org/proxy?keyref=Help{major}{minor}:{keyref}&lang={langcode}';
| Labels |
Added:
?
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28088.
If I am right, first PR was this: #24927
I applied this patch and run composer i and npm ci.
I opened user manager and clicked Help (Aide). Help Site https://help.joomla.org/proxy?keyref=Help40:Users_User_Manager&lang=fr was opened.
I opened some more Help Sites and had no problems.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28088.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28088.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-02 13:30:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
thanks
Delete
\administrator\help\helpsites.xml?