? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Feb 2020

Removes the duplicate grid-template-areas code as discussed in #28084

(Nice result from getting the lint working again)

codereview and lint test results

avatar brianteeman brianteeman - open - 26 Feb 2020
avatar brianteeman brianteeman - change - 26 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2020
Category Front End Templates (site)
avatar Quy
Quy - comment - 28 Feb 2020

I have tested this item successfully on 86c9a2b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28086.

avatar Quy Quy - test_item - 28 Feb 2020 - Tested successfully
avatar astridx
astridx - comment - 29 Feb 2020

I have tested this item successfully on 86c9a2b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28086.

avatar astridx astridx - test_item - 29 Feb 2020 - Tested successfully
avatar astridx
astridx - comment - 29 Feb 2020

I tested this.

  1. git fetch origin pull/28086/head:cass_fix_grid and checkout head:cass_fix_grid

2. npm ci

  1. I added some Modules.

  2. In Front end Cassiopeia was fine.

Home
Home(1)

avatar astridx astridx - change - 29 Feb 2020
Status Pending Ready to Commit
avatar wilsonge wilsonge - change - 2 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-02 14:13:45
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 2 Mar 2020
avatar wilsonge wilsonge - merge - 2 Mar 2020
avatar wilsonge
wilsonge - comment - 2 Mar 2020

Thanks guys!

avatar brianteeman
brianteeman - comment - 2 Mar 2020

Thanks

Add a Comment

Login with GitHub to post a comment