Feeling Lucky
?
?
[#28035] - [4.0] Remove commented code
- Fixed in Code Base
- 23 Feb 2020
- Medium
- Build: 4.0-dev
- # 28035
- Diff
- rdeutz:remove_comments
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Cleanp of the scss files removeing commented code and unnecessary selectors
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
brianteeman
- comment
- 23 Feb 2020
Really frustrating that I fixed all of this and more previously
astridx
- comment
- 23 Feb 2020
I have tested this item
I had a look into the Code, I applied the patch and found no issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28035.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 23 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28035.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
richard67
- comment
- 23 Feb 2020
@rdeutz I've allowed myself to commit @HLeithner suggested codestyle changes.
| Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-23 20:57:46 |
| Closed_By | ⇒ | richard67 |
richard67
- comment
- 23 Feb 2020
Thanks.
I have tested this item✅ successfully on 914955d
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28035.