Styling for SVGs like this should not be done in the template CSS. They should be in the actual SVG file

why?

Am 23.02.2020 um 17:04 schrieb Lodder:

Styling for SVGs like this should not be done in the template CSS.
They should be in the actual SVG file

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/28034?email_source=notifications&email_token=AAI6HM5I6IYSI6QR3EK22S3REKNCNA5CNFSM4KZ3T6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMV7SBA#issuecomment-590084356,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI6HMYEJ4B3CU2ZOB3TMM3REKNCNANCNFSM4KZ3T6YA.

Before patch with this PR:

After patch with this PR:

So to me this PR looks ok.

@C-Lodder Do you think it is wrong?

I have tested this item ✅ successfully on f6330e5

Works as shown in the screenshots in my previous comment.

@C-Lodder Please protest if PR is wrong.

@C-Lodder is correct

I have not tested this item.

@richard67 @angieradtke Because users may want to use their own logo. Any SVG styling done in the template CSS could potentially affect their logo.

Keep the SVG styling in the SVG

If  s.b. changed the  header-bg- color to a lighter one, he needs a
darker logo-color.
To make it more flexible  we can do it  in future like that:

svg path, svg polyline
{

fill: var(--atum-bg-light);

}

So what is the reason, to do it only in the svg- file ?

Am 23.02.2020 um 17:33 schrieb Brian Teeman:

@C-Lodder https://github.com/C-Lodder is correct

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/28034?email_source=notifications&email_token=AAI6HM5Q3EIZAPR5GO3RNSDREKQMDA5CNFSM4KZ3T6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWAOPQ#issuecomment-590087998,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI6HM5Z57HLLAKGIS3UJBTREKQMDANCNFSM4KZ3T6YA.

@angieradtke see above

hm -   in this case they can use a png or a jpg ?

Am 23.02.2020 um 17:55 schrieb Lodder:

@richard67 https://github.com/richard67 @angieradtke
https://github.com/angieradtke Because users may want to use their
own logo. Any SVG styling done in the template CSS could potentially
affect their logo.

Keep the SVG styling in the SVG

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/28034?email_source=notifications&email_token=AAI6HMZ74JN7WZCOGTO5WX3REKS7ZA5CNFSM4KZ3T6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWBA7Y#issuecomment-590090367,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI6HM3P7OKDKNCCOJKBCATREKS7ZANCNFSM4KZ3T6YA.

hm - in this case they can use a png or a jpg ?

Why prevent users from using basic vector logos?

Just move the styling to the SVG file and there won't be any issues.

this is a quick fix for now, missing l an d ! should be white . If we want we can change the svg later

whats the panic rush? Why fist it twice?

Maybe Brian you are familar with the logos.
Logo should be changed to  joomla-logo -white in the index.php.
I know that something with the logo will be done  in the js-Files.
I don't have a complete picture of these pendencies.

and  we should think about whether we should make the logo color
configurable.

Am 23.02.2020 um 18:51 schrieb Brian Teeman:

whats the panic rush? Why fist it twice?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/28034?email_source=notifications&email_token=AAI6HM3G7N2TXL6GNWCLZZ3REKZQRA5CNFSM4KZ3T6YKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWCPHQ#issuecomment-590096286,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAI6HM6OJ2VE5A6NI6QZVKDREKZQRANCNFSM4KZ3T6YA.

Please test #28038

see #28038 helps