[#28010] - [3] com_tags, Tagged Items, Remove error-prone structured data markup
- Fixed in Code Base
- 4 Mar 2020
- Medium
- Build: staging
- # 28010
- Diff
- ReLater:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27358
and additional find with tagged com_banners.category
Testing Instructions
-
Create a tag
TagA. -
Add this tag to some articles.
-
Add intro images to these articles.
-
Go to
Banners: Categories -
Add tag
TagAto a category. -
Create a menu item of type "Tagged Items":
-
Leave
Content Typeempty. -
Tabulator
Tag Options> Set "Item Image" to "Show" -
Go to https://search.google.com/structured-data/testing-tool
and test the new menu item/front-end link.
Expected result
- No errors
Actual result
2 errors:
- Error 1 (com_banners.category item):
A value for the url field is required.
Not solvable because a com_banners.category item never has a link/url.
That's the reason why I removed the (here anyway needless(!)) markup completely instead of solving just error 2.
- Error 2:
"Duplicate values for itemListElement.url are not allowed."
Reason: Two links inside ItemList marked as "url" (1 around headline, 1 around images).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28010.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28010.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-04 20:50:03 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
Thanks, if this is needed by a site owner a better override should be possible.
I have tested this item✅ successfully on 9ace9e7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28010.