? ? Pending
Pull Request for # 28008

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
21 Feb 2020

Pull Request for Issue #28008.

Summary of Changes

Fixes filtering categories and contacts by tags in backend.

Testing Instructions

Create some categories and contacts with tags.
Filter categories/contacts by single and multiple tags.

Expected result

Categories/contacts filtered.

Actual result

Categories/contacts not filtered.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 21 Feb 2020
avatar SharkyKZ SharkyKZ - change - 21 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Feb 2020
Category Administration com_categories
avatar SharkyKZ SharkyKZ - change - 21 Feb 2020
Rel_Number 28008
Relation Type Pull Request for
Labels Added: ?
avatar Quy
Quy - comment - 21 Feb 2020

The notice is gone, however, items are not filtered.

avatar ChristineWk
ChristineWk - comment - 21 Feb 2020

@Quy Confirm both. It's not successful now?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28009.

avatar SharkyKZ SharkyKZ - change - 21 Feb 2020
Title
[4.0] Fix array to string conversion notice
[4.0] Fix filtering categories by tags
avatar SharkyKZ SharkyKZ - edited - 21 Feb 2020
avatar SharkyKZ SharkyKZ - change - 21 Feb 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 21 Feb 2020
avatar SharkyKZ
SharkyKZ - comment - 21 Feb 2020

PR updated. Please test again.

avatar SharkyKZ SharkyKZ - change - 21 Feb 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 21 Feb 2020
avatar Quy
Quy - comment - 21 Feb 2020

I have tested this item successfully on 46b1667


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28009.

avatar Quy Quy - test_item - 21 Feb 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 22 Feb 2020

Hold on, same issue exists in com_contact.

avatar SharkyKZ SharkyKZ - change - 22 Feb 2020
Title
[4.0] Fix filtering categories by tags
[4.0] Fix filtering categories and contacts by tags
avatar SharkyKZ SharkyKZ - edited - 22 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2020
Category Administration com_categories Administration com_categories com_contact
avatar SharkyKZ SharkyKZ - change - 22 Feb 2020
The description was changed
avatar SharkyKZ SharkyKZ - edited - 22 Feb 2020
avatar SharkyKZ
SharkyKZ - comment - 22 Feb 2020

PR updated. Please test again.

avatar Quy
Quy - comment - 23 Feb 2020

I have tested this item successfully on 91cf05f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28009.

avatar Quy Quy - test_item - 23 Feb 2020 - Tested successfully
avatar alikon
alikon - comment - 23 Feb 2020

I have tested this item successfully on 91cf05f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28009.

avatar alikon alikon - test_item - 23 Feb 2020 - Tested successfully
avatar alikon alikon - change - 23 Feb 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 23 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28009.

avatar richard67
richard67 - comment - 23 Feb 2020

@SharkyKZ To be honest: I have no idea how filtering by tags shall work when filtering by multiple tags. Shall the articles be shown which contain any of the tags in the filter, like it is with this PR? Or shall only articles be shown which contain all of the tags in the filter?

avatar SharkyKZ
SharkyKZ - comment - 23 Feb 2020

Any of the tags, same as in other components.

avatar richard67 richard67 - change - 23 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-23 22:15:45
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 23 Feb 2020
avatar richard67 richard67 - merge - 23 Feb 2020
avatar richard67
richard67 - comment - 23 Feb 2020

Thanks.

Add a Comment

Login with GitHub to post a comment