[#27987] - Update default.php
- Fixed in Code Base
- 4 Apr 2020
- Medium
- Build: staging
- # 27987
- Diff
- fertxunonimo:breadcrumbs_tmpl_default_bug
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
I have found this PHP Notice: Undefined property: stdClass::$name in /modules/mod_breadcrumbs/tmpl/default.php on line 12. I have changed the name property to title to solve the error.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I am not able to reproduce the PHP notice.
Before PR: <div aria-label="breadcrumbs" role="navigation">
After PR: <div aria-label="Breadcrumbs" role="navigation">
Sorry for the inconvenience, it's my first time I use GitHub.
Here is my test enviroment:
I have installed Gantry5 and Hellium theme. Breadcrumbs module is inserted on theme layout at Intro section.
It seems like gantry change somehow the Object and the $name is not defined so I changed the name to title and warnng has gone.
Hope this help to you!
Regards
F.
you shuold report this issue there
Gantry5 and Hellium theme
closing as not a core issue
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-20 18:04:57 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
?
|
||
This should be re-opened. Issue can be reproduced by rendering module manually when no breadcrumbs module is published:
$module = JModuleHelper::getModule('mod_breadcrumbs');
echo JModuleHelper::renderModule($module);
And it makes more sense to use the human readable title rather than non-translatable name.
The undefined property issue can be fixed by adding name property here:
joomla-cms/libraries/src/Helper/ModuleHelper.php
Lines 56 to 67 in 914a371
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-02-20 18:04:57 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
@fertxunonimo please provide testing instructions for this PR. Without them, no one will be able to test and confirm it fixes referenced bug.
Install testing sample data.
Go to the frontend,
Click Article Category List.
View page source.
Before PR:
After PR:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27987.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27987.
| Status | Pending | ⇒ | Ready to Commit |
RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27987.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-04 12:46:28 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
Removed: ? |
||
Shouldn't this be escaped?
@fertxunonimo Can you please provide testing instructions for this PR?