Feeling Lucky
?
[#27986] - [4.0] Use MVC Factory to get Tag table
- Fixed in Code Base
- 23 Feb 2020
- Medium
- Build: 4.0-dev
- # 27986
- Diff
- SharkyKZ:j4/deprecated/tag-table
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Drops the use of TagsTableTag alias in Joomla\CMS\Helper\TagsHelper.
Testing Instructions
Test that searching tags in tag field and creating tags on the fly still works.
Expected result
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
SharkyKZ
- comment
- 19 Feb 2020
No, issues are not related.
If not, could that issue be a problem when testing this PR here as described above?
Yes, I ran into the other issue when testing this.
astridx
- comment
- 23 Feb 2020
I have tested this Patch successful.
- git fetch origin pull/27986/head:j4/depreciated/tag-table
- j4/depreciated/tag-table
- No new install or
npm ciis needed. - I created an Article and by this I I created tags on the fly.
- I could not find a place, where I could test the method
getTagTreeArray(). So I used it in a own component.
I tested with the current 4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7.
astridx
- comment
- 23 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27986.
astridx
- comment
- 23 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27986.
jwaisner
- comment
- 23 Feb 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27986.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 23 Feb 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27986.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-23 20:33:38 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 23 Feb 2020
Thanks.
Is this related to issue #27985 ? If not, could that issue be a problem when testing this PR here as described above?