[#27967] - 2FA - Joomla Secret Key - autocomplete="one-time-code"
- Fixed in Code Base
- 7 Apr 2020
- Medium
- Build: staging
- # 27967
- Diff
- alikon:patch-105
- Pending Hound Hound is busy sniffing around... Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27580 .
Summary of Changes
changed to autocomplete="one-time-code" for the 2fa or secret key
Testing Instructions
Activate 2FA authentication on backend
save
Disconnect
Try to log in (on backend or frontend)using a password manager (i.e. 1Password or Lastpass)
Expected result
The password manager recognize and fill the 3 fields
Actual result
secret key not recognized
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
What password manager did you have used?
Il mar 18 feb 2020, 12:20 Vio Cassel notifications@github.com ha scritto:
I have tested this item
✅ successfully on 843af61
843af61This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/tracker/joomla-cms/27967.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/27967?email_source=notifications&email_token=AABMLMP25GTUQF6OHIXZF73RDPABXA5CNFSM4KWW3NJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMBTOKI#issuecomment-587413289,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABMLMNYO7OETGCI25OZHG3RDPABXANCNFSM4KWW3NJA
.
| Labels |
Added:
?
|
||
Should't this also be done for com_users login and mod_login?
yes, but before, i want to be sure that the changes works with most of the password managers
Seams like the id change helped. Maye we can overcome the id issue by overriding the in the core Templates and dont touch the core Layouts in 3.x and with 4.x we update the core layout too. :-D
I'd do the autocomplete here and then the id change in 3.10
| Category | Modules Administration | ⇒ | Modules Administration Front End Templates (site) |
| Category | Modules Administration Front End Templates (site) | ⇒ | Modules Administration Templates (admin) Front End Templates (site) |
| Category | Modules Administration Front End Templates (site) Templates (admin) | ⇒ | Administration com_joomlaupdate Modules Templates (admin) Front End Templates (site) |
| Category | Modules Administration Front End Templates (site) Templates (admin) com_joomlaupdate | ⇒ | Administration com_joomlaupdate Modules Templates (admin) Front End com_users Templates (site) |
let's do it that way then
| Title |
|
||||||
Cool let's get some tests here then :)
I will share this in the Dutch Community so we can test different password managers.
I have tested this item
I tried my best to make it work.
The result before and after are exactly the same.
Using 1Password latest version on MacOS Catalina 10.15.4
Browsers Chrome, Safari and Firefox.
The field is not filled.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27967.
Update:
If I change the field name="secretkey" too name="one-time-code" it works.
The autocomplete change doesn't do anything for me.
I'd do the autocomplete here and then the id change in 3.10
3.10 and 4 :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-03 11:44:37 |
| Closed_By | ⇒ | alikon |
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-04-03 11:44:37 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-07 13:22:47 |
| Closed_By | ⇒ | HLeithner |
Thanks
I have tested this item✅ successfully on 843af61
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27967.