User tests: Successful: Unsuccessful:
Pull Request for Issue #27947 .
Use the opcache_invalidate
PHP function to save global configuration.
Change the global configuration and save it.
The Configuration file is updated.
The configuration file is not updated. The new configuration is only saved in the session. If you log out and log in again, the changed configuration is lost.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config |
@SharkyKZ Is the change in this PR here correct? If so, don't we need that at other places too then?
./administrator/components/com_config/src/Model/ApplicationModel.php:813: if (function_exists('opcache_invalidate'))
./administrator/components/com_config/src/Model/ApplicationModel.php:815: opcache_invalidate($file);
./administrator/components/com_joomlaupdate/restore_finalisation.php:79: if (function_exists('opcache_reset'))
./administrator/components/com_joomlaupdate/restore_finalisation.php:81: opcache_reset();
./administrator/components/com_joomlaupdate/restore.php:8314: if (function_exists('opcache_invalidate'))
./administrator/components/com_joomlaupdate/restore.php:8316: opcache_invalidate($filename);
@richard67 haven't tested this yet. But if it's correct, it should only be needed in this file.
@twister65 Maybe you could mention in your testing instructions that it needs opcache on to test this? For insider readers it is clear, but maybe not for other testers.
Labels |
Added:
?
|
Category | Administration com_config | ⇒ | Administration com_config com_joomlaupdate |
@twister65 One more call to opcache_invalidate
in file ./administrator/components/com_joomlaupdate/restore.php
, line 8316.
Here it is done, have a good week.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-16 21:08:54 |
Closed_By | ⇒ | wilsonge |
Merged on review. Thanks!
@twister65 It seems your actual result in this description is wrong. If it really would be "As expected.", this PR would do nothing. The actual result shall describe the situation without this PR applied, so you can use the actual result from the issue. The expected result then describes what happens with your PR applied.