? Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
16 Feb 2020

Pull Request for Issue #27947 .

Summary of Changes

Use the opcache_invalidate PHP function to save global configuration.

Testing Instructions

Change the global configuration and save it.

Expected result

The Configuration file is updated.

Actual result

The configuration file is not updated. The new configuration is only saved in the session. If you log out and log in again, the changed configuration is lost.

Documentation Changes Required

avatar twister65 twister65 - open - 16 Feb 2020
avatar twister65 twister65 - change - 16 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2020
Category Administration com_config
avatar richard67
richard67 - comment - 16 Feb 2020

@twister65 It seems your actual result in this description is wrong. If it really would be "As expected.", this PR would do nothing. The actual result shall describe the situation without this PR applied, so you can use the actual result from the issue. The expected result then describes what happens with your PR applied.

avatar twister65 twister65 - change - 16 Feb 2020
The description was changed
avatar twister65 twister65 - edited - 16 Feb 2020
avatar richard67
richard67 - comment - 16 Feb 2020

@SharkyKZ Is the change in this PR here correct? If so, don't we need that at other places too then?

./administrator/components/com_config/src/Model/ApplicationModel.php:813:               if (function_exists('opcache_invalidate'))
./administrator/components/com_config/src/Model/ApplicationModel.php:815:                       opcache_invalidate($file);
./administrator/components/com_joomlaupdate/restore_finalisation.php:79:                        if (function_exists('opcache_reset'))
./administrator/components/com_joomlaupdate/restore_finalisation.php:81:                                opcache_reset();
./administrator/components/com_joomlaupdate/restore.php:8314:                                   if (function_exists('opcache_invalidate'))
./administrator/components/com_joomlaupdate/restore.php:8316:                                           opcache_invalidate($filename);
avatar SharkyKZ
SharkyKZ - comment - 16 Feb 2020

@richard67 haven't tested this yet. But if it's correct, it should only be needed in this file.

avatar richard67
richard67 - comment - 16 Feb 2020

@twister65 Maybe you could mention in your testing instructions that it needs opcache on to test this? For insider readers it is clear, but maybe not for other testers.

avatar twister65 twister65 - change - 16 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2020
Category Administration com_config Administration com_config com_joomlaupdate
avatar richard67
richard67 - comment - 16 Feb 2020

@twister65 One more call to opcache_invalidate in file ./administrator/components/com_joomlaupdate/restore.php, line 8316.

avatar twister65
twister65 - comment - 16 Feb 2020

Here it is done, have a good week.

avatar wilsonge wilsonge - change - 16 Feb 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-16 21:08:54
Closed_By wilsonge
avatar wilsonge wilsonge - close - 16 Feb 2020
avatar wilsonge wilsonge - merge - 16 Feb 2020
avatar wilsonge
wilsonge - comment - 16 Feb 2020

Merged on review. Thanks!

Add a Comment

Login with GitHub to post a comment