? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
16 Feb 2020

Related issue: #27059

Summary of Changes

WIP Work on adding back the ability to set site + admin languages in the installer. For now use the installer, install an extra language there. Then once installed successfully change your URL in the browser to <YOUR_JOOMLA_ROOT_URL>/installation/index.php?view=defaultlanguage (obviously this needs to be integrated into the flow see steps left below)

This reinstates back the old view for configuring the default site + admin languages - so that people who don't speak english as a native language are able to set the admin default language before they start to configure things.

Things left to do

  • Remove the installLocalisedContent options + related code - this will still belong in the administrator area
  • Figure out the flow of accessing this view (after installing a language an autoredirect or?)
  • Should this new view be merged with the existing installation install languages view
  • General Styling/ HTML Structure (This is give or take the same thing from J3 - I've just tweaked things to render via JForm and swapped to switcher)

Testing Instructions

TODO

Documentation Changes Required

N/A

avatar wilsonge wilsonge - open - 16 Feb 2020
avatar wilsonge wilsonge - change - 16 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2020
Category Installation Language & Strings JavaScript
avatar wilsonge wilsonge - change - 16 Feb 2020
Title
WIP on adding back ability to set site + admin languages
[4.0] WIP on adding back ability to set site + admin languages in installer
avatar wilsonge wilsonge - edited - 16 Feb 2020
avatar infograf768
infograf768 - comment - 16 Feb 2020

Do you really want to add back installing multilingual sample data?
I am asking because, at looking at code, i see a new xml with the related fields.
I thought we should now only use the module/plugin.

avatar wilsonge
wilsonge - comment - 16 Feb 2020

No I don’t. That’s why removing it is one of the items in my to do list ;)

avatar infograf768
infograf768 - comment - 17 Feb 2020

@wilsonge
Then please delete this new defaultlanguage.xml which only contains multilingual related stuff...
https://github.com/joomla/joomla-cms/pull/27951/files#diff-36940170e4e897341f3f5ac286af1332

avatar wilsonge
wilsonge - comment - 17 Feb 2020

Well I thought we'd still want activateMultilanguage and activatePluginLanguageCode?

avatar infograf768
infograf768 - comment - 17 Feb 2020

Well I thought we'd still want activateMultilanguage and activatePluginLanguageCode?

It includes installLocalisedContent. What is it for?

Please just take a final decision on what you want to install during J installation.

avatar infograf768
infograf768 - comment - 13 Mar 2020

Closing as we have a working PR #28328

avatar infograf768 infograf768 - change - 13 Mar 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-03-13 10:21:25
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 13 Mar 2020

Add a Comment

Login with GitHub to post a comment