? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Feb 2020

Completes the @todo task as the tabs custom element has been merged. As far as I can tell the reference to modals is a copy paste error

avatar brianteeman brianteeman - open - 13 Feb 2020
avatar brianteeman brianteeman - change - 13 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Feb 2020
Category Administration com_config JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 13 Feb 2020

Which reference to modals?

avatar richard67
richard67 - comment - 13 Feb 2020

I see, thanks.

avatar richard67
richard67 - comment - 13 Feb 2020

@brianteeman How to test? Code review? Or real test?

avatar brianteeman
brianteeman - comment - 13 Feb 2020

code review and make sure tabs work as they did before

avatar richard67
richard67 - comment - 13 Feb 2020

Thanks. Code review looks good, tabs I can test tonight after work.

avatar richard67
richard67 - comment - 13 Feb 2020

I have tested this item successfully on d222fd8

Code review good. Tabs still work in Global Configuration.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27917.

avatar richard67 richard67 - test_item - 13 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 13 Feb 2020

I have tested this item successfully on d222fd8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27917.

avatar Quy Quy - test_item - 13 Feb 2020 - Tested successfully
avatar Quy Quy - change - 13 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 13 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27917.

avatar wilsonge wilsonge - change - 16 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-16 12:16:14
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 16 Feb 2020
avatar wilsonge wilsonge - merge - 16 Feb 2020
avatar wilsonge
wilsonge - comment - 16 Feb 2020

Thanks!

avatar brianteeman
brianteeman - comment - 16 Feb 2020

thx

Add a Comment

Login with GitHub to post a comment