? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Feb 2020

Pull request for #27858

This is not perfect as it still changes size slightly but its better than before where it moved from right to left. The change was to add preserveAspectRatio="xMinYMin meet" into the svg see http://tutorials.jenkov.com/svg/svg-viewport-view-box.html

before

logo

after

after

avatar brianteeman brianteeman - open - 10 Feb 2020
avatar brianteeman brianteeman - change - 10 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2020
Category Administration Templates (admin)
avatar C-Lodder
C-Lodder - comment - 10 Feb 2020

SVG should be minified. You can use this: https://jakearchibald.github.io/svgomg/

avatar brianteeman
brianteeman - comment - 10 Feb 2020

Happy for someone else to do that. It was the minification that broke the svg in the first place

avatar C-Lodder
C-Lodder - comment - 10 Feb 2020

Does adding preserveAspectRatio="xMinYMin meet" to the original minified file work?

avatar brianteeman brianteeman - change - 10 Feb 2020
Labels Added: ?
avatar brianteeman
brianteeman - comment - 10 Feb 2020

Good idea @C-Lodder done that

avatar Quy
Quy - comment - 12 Feb 2020

I have tested this item successfully on a2c562e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27880.

avatar Quy Quy - test_item - 12 Feb 2020 - Tested successfully
avatar jwaisner jwaisner - test_item - 12 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 12 Feb 2020

I have tested this item successfully on a2c562e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27880.

avatar jwaisner jwaisner - change - 12 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 12 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27880.

avatar rdeutz rdeutz - close - 16 Feb 2020
avatar rdeutz rdeutz - merge - 16 Feb 2020
avatar rdeutz rdeutz - change - 16 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-16 08:45:03
Closed_By rdeutz
Labels Added: ?
avatar brianteeman
brianteeman - comment - 16 Feb 2020

thank you - not perfect but better than it was

Add a Comment

Login with GitHub to post a comment