? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Feb 2020

Although you can kind of use the admin with IE it is not supported and will not work 100%. This PR uses css to detect if you are using ie10 or 11 and displays a warning if you are. (hopefully this will save us from numerous reports that something doesn't work)

To test npm i or node build.js --compile.css

Make sure that you do not see a message with your normal browser
If you have access to IE10 or 11 then make sure you do see a message

Expected result on IE

image

avatar brianteeman brianteeman - open - 10 Feb 2020
avatar brianteeman brianteeman - change - 10 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2020
Category Administration Language & Strings Templates (admin)
2f2ceff 10 Feb 2020 avatar brianteeman typo
avatar brianteeman brianteeman - change - 10 Feb 2020
Labels Added: ? ?
f82dcd9 10 Feb 2020 avatar brianteeman cs
avatar Fedik Fedik - test_item - 10 Feb 2020 - Tested successfully
avatar Fedik
Fedik - comment - 10 Feb 2020

I have tested this item successfully on 2c82c3d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879.

avatar Quy Quy - test_item - 10 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 10 Feb 2020

I have tested this item successfully on b2bd0ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879.

avatar Quy Quy - change - 10 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 10 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879.

avatar jwaisner jwaisner - change - 10 Feb 2020
Status Ready to Commit Pending
avatar jwaisner
jwaisner - comment - 10 Feb 2020

Setting back to pending. Missing 1 more test before moving to commit changes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879.

avatar Quy
Quy - comment - 10 Feb 2020

It is only coding style change that does not affect test results.

avatar Quy Quy - change - 10 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 10 Feb 2020

@Quy @brianteeman That detail needs to be called out in testing. The notes do not indicate this and will only cause confusion and problems for Testers.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879.

avatar ciar4n ciar4n - test_item - 10 Feb 2020 - Tested successfully
avatar ciar4n
ciar4n - comment - 10 Feb 2020

I have tested this item successfully on b2bd0ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27879.

avatar Quy Quy - change - 11 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-11 09:50:20
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 11 Feb 2020
avatar Quy Quy - merge - 11 Feb 2020
avatar brianteeman
brianteeman - comment - 11 Feb 2020

thanks

Add a Comment

Login with GitHub to post a comment