[#27874] - [4.0] Fix undefined property when editing stages/transitions
- Fixed in Code Base
- 9 Feb 2020
- Medium
- Build: 4.0-dev
- # 27874
- Diff
- wilsonge:undefined_property_workflows
- Error continuous-integration/drone/pr Build was killed Details
- Error continuous-integration/appveyor/pr AppVeyor build cancelled Details
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26306
Summary of Changes
Fixes undefined property in error logs when editing a stage or transition.
Testing Instructions
Create a new workflow.
Under Stages column, click the count badge.
Edit Unpublished.
Click Save & Close.
View PHP error log.
Trying to get property 'workflow_id' of non-object in \administrator\components\com_workflow\Model\StageModel.php on line 163
Do the same under the Transitions column.
Trying to get property 'workflow_id' of non-object in \administrator\components\com_workflow\Model\TransitionModel.php on line 89
After patching neither entries will be added to the error log
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27874.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27874.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-09 17:48:20 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks.
I have tested this item✅ successfully on a5bca08
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27874.