? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
9 Feb 2020

Pull Request for Issue #26306

Summary of Changes

Fixes undefined property in error logs when editing a stage or transition.

Testing Instructions

Create a new workflow.
Under Stages column, click the count badge.
Edit Unpublished.
Click Save & Close.
View PHP error log.

Trying to get property 'workflow_id' of non-object in \administrator\components\com_workflow\Model\StageModel.php on line 163

Do the same under the Transitions column.

Trying to get property 'workflow_id' of non-object in \administrator\components\com_workflow\Model\TransitionModel.php on line 89

After patching neither entries will be added to the error log

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 9 Feb 2020
avatar wilsonge wilsonge - change - 9 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category Unit Tests Repository Administration
avatar wilsonge wilsonge - change - 9 Feb 2020
Title
Undefined property workflows
[4.0] Fix undefined property workflows
avatar wilsonge wilsonge - edited - 9 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2020
Category Unit Tests Repository Administration Administration com_workflow
avatar wilsonge wilsonge - change - 9 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-09 16:36:12
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 9 Feb 2020
avatar wilsonge wilsonge - change - 9 Feb 2020
Status Closed New
Closed_Date 2020-02-09 16:36:12
Closed_By wilsonge
avatar wilsonge wilsonge - change - 9 Feb 2020
Status New Pending
avatar wilsonge wilsonge - reopen - 9 Feb 2020
avatar wilsonge wilsonge - change - 9 Feb 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-02-09 16:36:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Feb 2020

Add a Comment

Login with GitHub to post a comment