[#27857] - [4.0] Remove Fade effect
- Fixed in Code Base
- 9 Feb 2020
- Medium
- Build: 4.0-dev
- # 27857
- Diff
- brianteeman:fade
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Faster login
Removes the delay which is counter-logic
Solves stutter bug #25904
Solves internet explorer bug #26005
(of course it wont work nicely with IE but at least someone could now log in if they have an emergency AND it opens the possibility to add a "does not work with IE" message" which you can't before this PR
Testing Instructions
Apply PR and then run npm i
Check that login works
It should now be faster and smoother
Bonus try and open the admin with ie11
(First of several PR on atum)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change Installation |
I have tested this item
Login page no longer fades on login. Confirmed clean install is successful. Login is faster.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.
Please don't delete _mixin.scss and @import so the same mixin code for LTR/RTL can be implemented for the backend. Thanks.
But it's not being used after this pr
Ok. Will do in the morning
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Administration Templates (admin) JavaScript Repository NPM Change Installation | ⇒ | Administration Templates (admin) JavaScript Repository NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.
Tested with success, too. Will merge.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-09 18:45:54 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks. Btw. my nick name for my German friends is "Fade", so I first was confusde about the title ;-)
@brianteeman Close #25904?
@Quy you requested that this empty mixin file was not removed as you had a PR that would be using it
its nine months later and the empty file is still there. did you forget your pr or was it done a different way.
In other words we should remove this empty file and references to it
I have tested this item✅ successfully on 2e3b4ee
Login page no longer fades on login. Confirmed clean install is successful. Login is faster.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27857.