[#27839] - [4.0] Prevent saving content when creating category fails
- Fixed in Code Base
- 9 Mar 2020
- Medium
- Build: 4.0-dev
- # 27839
- Diff
- SharkyKZ:j4/categories-on-the-fly
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Category field is required in content item forms but it's possible to save content items without a valid category when creating category on the fly fails. This changes that.
Testing Instructions
Create a category. Call it whatever but set its alias as duplicate.
Create or edit an article/contact/newsfeed/banner.
In the category field enter Duplicate to create category on the fly.
Save.
Expected result
Saving fails with error:
Save failed with the following error: Another category with the same parent category has the same alias (remember it may be a trashed item).
Actual result
Article is either saved or we get this:
Argument 1 passed to Joomla\Component\Content\Administrator\Model\ArticleModel::getWorkflowByCategory() must be of the type integer, null given
Contact saving fails with error:
This category is invalid.
Newsfeeds and banners are saved.
Documentation Changes Required
IDK.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_newsfeeds Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
Yes. I did not make a PR for J3 because some may consider this B/C breaking change
I have tested this item
Correct error is presented in articles, contacts, newsfeeds, and banners.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27839.
I have tested this item
Confirmed the issue
Confirmed the fix by testing in com_content
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27839.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27839.
| Labels |
Added:
?
|
||
Contact has a check in table class but other components allow saving without category.
Let's roll the check for a category in the Table level into j3 - no need to port the rest of it.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-09 11:56:04 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Is this true in joomla 3 as well?