Information Required ?
avatar Milglius
Milglius
7 Feb 2020

Steps to reproduce the issue

Install Joomla
Go to extensions >> Templates >> Templates
Open protostar template.
Click copy template on top left.

copy protostar template it creates strange extensions file /css/template.css?c250e51230c550e0

Expected result

/css/template.css

Actual result

/css/template.css?c250e51230c550e0

System information (as much as possible)

j 3,9,15, php 7.4.2

Additional comments

avatar Milglius Milglius - open - 7 Feb 2020
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 Feb 2020
avatar brianteeman
brianteeman - comment - 7 Feb 2020

Do you have any cache extensions installed?

avatar Milglius
Milglius - comment - 7 Feb 2020

no

avatar brianteeman
brianteeman - comment - 7 Feb 2020

I can not replicate this.

avatar Quy
Quy - comment - 7 Feb 2020

I can not replicate too.

avatar Fedik
Fedik - comment - 7 Feb 2020

@Milglius where do you see this file /css/template.css?c250e51230c550e0?

avatar Quy Quy - change - 8 Feb 2020
Labels Added: Information Required
avatar Quy Quy - labeled - 8 Feb 2020
avatar infograf768 infograf768 - change - 8 Feb 2020
Status New Information Required
avatar Twincarb
Twincarb - comment - 8 Feb 2020

Isn't it the intended behaviour of Protostar to set a version to template.css?

// Add Stylesheets
JHtml::_('stylesheet', 'template.css', array('version' => 'auto', 'relative' => true));


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27838.
avatar brianteeman
brianteeman - comment - 8 Feb 2020

yes it is but from the description of the report he is saying that this is the filename created

avatar Fedik
Fedik - comment - 8 Feb 2020

but not saying that it create in file system,
translations may be not perfect ?

I suspect he seen it in the page source code, that of course not a bug

avatar brianteeman
brianteeman - comment - 8 Feb 2020

well lets wait a few days for a reply before closing

avatar ChristineWk
ChristineWk - comment - 8 Feb 2020

I suspect he seen it in the page source code, that of course not a bug

Agree. Checked some URLs to find out the "difference" :-)

... /templates/mytemplatecopy/css/template.css" rel="stylesheet" type="text/css" />
.../templates/mytemplatecopy/css/user.css" rel="stylesheet" type="text/css" />

.../templates/protostar/css/template.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" />
.../templates/protostar/css/user.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" />

avatar Quy
Quy - comment - 13 Feb 2020

@ChristineWk Please advise which page(s) that shows the "difference".

avatar ChristineWk
ChristineWk - comment - 13 Feb 2020

@Quy The first 2 lines: From an older Protostar (of course up to date) starting years ago > Template copy.
The second 2 lines: I think, when creating a new Protostar, then it will built as above automatically.

avatar Quy
Quy - comment - 13 Feb 2020

OK. So this is not an issue, but a misunderstanding by the user looking at the page source and not the file system and how it is generated now vs previously?

avatar ChristineWk
ChristineWk - comment - 13 Feb 2020

Agree again that is not a bug :-) Checked differences via page source. From an URL, created years ago.

avatar Quy
Quy - comment - 13 Feb 2020

Closing as not a bug. Please provide details/screenshots if still an issue. Thanks.

avatar Quy Quy - close - 13 Feb 2020
avatar Quy Quy - change - 13 Feb 2020
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2020-02-13 17:07:17
Closed_By Quy
avatar Twincarb
Twincarb - comment - 13 Feb 2020

@Quy wasn't this being kept open for the OP @Milglius to respond?

avatar Quy
Quy - comment - 13 Feb 2020

@Twincarb It is not locked so he can still respond. If reproducible with additional information it will be reopened.

avatar Milglius
Milglius - comment - 14 Feb 2020

It is in page source code. ChristineWk why it's not a bug? My english not the best hope you understand me now, thanks.

copy protostar name it mytemplatecopy and instead of this

... /templates/mytemplatecopy/css/template.css" rel="stylesheet" type="text/css" />
.../templates/mytemplatecopy/css/user.css" rel="stylesheet" type="text/css" />

you get this ugly code

.../templates/mytemplatecopy/css/template.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" />
.../templates/mytemplatecopy/css/user.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" />

Why this ugly code addition is the intended behaviourand and not the bug? is there an option to get rid ?8e17160b713641b3cc489b29e3405a51 of it ?

avatar SniperSister
SniperSister - comment - 14 Feb 2020

That „ugly code“ is a hash of the file content. It will change when the linked file is changed, causing the browser to reload that file from the server instead of using the locally cached (and now outdated) file.

That’s not a bug, it’s a feature.

avatar Milglius
Milglius - comment - 14 Feb 2020

That code makes site slow. When was such feature introduced in protostar? How to disable such a feature?

avatar SniperSister
SniperSister - comment - 14 Feb 2020

That code makes site slow.

Because a hash is generated? Hell no, that has no measurable impact.

avatar Milglius
Milglius - comment - 14 Feb 2020

David what test you done on .../templates/mytemplatecopy/css/template.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" />
.../templates/mytemplatecopy/css/user.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" /> to claim this?

avatar SniperSister
SniperSister - comment - 14 Feb 2020

What have you tested to claim that it makes the site slow?

avatar Milglius
Milglius - comment - 14 Feb 2020

Joomla site . David when was such feature introduced in protostar? How to disable such a feature?

avatar brianteeman
brianteeman - comment - 14 Feb 2020

You should not disable it - it is there for very good reasons. (If you check other cms you will see they do the same/similar thing)

avatar Milglius
Milglius - comment - 14 Feb 2020

brian what reason it is?

avatar Fedik
Fedik - comment - 14 Feb 2020

brian what reason it is?

answer already was:

It will change when the linked file is changed, causing the browser to reload that file from the server instead of using the locally cached (and now outdated) file

Only correction, not when " linked file is changed" but when you update joomla, it is version based hash.
This to prevent old files loading when site updated, to avoid browser cache that may lead to unexpected behavior and bugs.

There 0 performance impact, the hash updated only once.

avatar Milglius
Milglius - comment - 14 Feb 2020

That code protostar template makes joomla site slow as hell. Do google PageSpeed Insights. It slows site by about 3 seconds.

So Fedik and David, what test you done to claim that 3 seconds is zero impact?

When was such feature introduced in protostar? How to disable such a feature?

avatar Twincarb
Twincarb - comment - 14 Feb 2020

@Milglius the change was made to the default template 3 years ago I have not seen any speed changes with it in place. If this caused a speed issue then it would have been reported over and over on the main forum.
Due to the complex number of variables that could be causing your issues then it would be better to open a post on the main support forum. https://forum.joomla.org/

avatar Milglius
Milglius - comment - 14 Feb 2020

Dave due to the complex number of closed but unsolved issues of joomla it would be better to https://developers.google.com/speed/pagespeed/insights/

Whese tests show how bad horrible joomla template performs with thisfeature not disabled on .../templates/mytemplatecopy/css/template.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" />
.../templates/mytemplatecopy/css/user.css?8e17160b713641b3cc489b29e3405a51" rel="stylesheet" /> to claim this?

please reopen this issue

avatar Fedik
Fedik - comment - 14 Feb 2020

@Milglius stop this nonsense, you have an issue on your side somewhere,
and I suspect you misunderstood what pagespeed/insights/ said to you.
The hash itself does not affect a performance.

If you need a help in solving of your problem, please follow @Twincarb comment, and ask for help at https://forum.joomla.org/

Add a Comment

Login with GitHub to post a comment