NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Feb 2020

PR for #26696

  1. Displays the dimension as 123px * 321px instead of 123 x 321
  2. Displays the size in KB not bytes and right align in the list

as this is js dont forget to do npm i

Before

image

After

image
image

avatar brianteeman brianteeman - open - 5 Feb 2020
avatar brianteeman brianteeman - change - 5 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2020
Category Administration com_media NPM Change
avatar brianteeman brianteeman - change - 6 Feb 2020
Labels Added: NPM Resource Changed ?
avatar jwaisner jwaisner - test_item - 6 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 6 Feb 2020

I have tested this item successfully on ae59a5c

Looks good. Tested with uploads as well to confirm that new display worked. Deleting files also works with no issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27819.

avatar Quy Quy - test_item - 6 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 6 Feb 2020

I have tested this item successfully on cc050a4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27819.

avatar Quy Quy - change - 6 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27819.

avatar brianteeman brianteeman - change - 6 Feb 2020
Labels Added: ?
avatar richard67
richard67 - comment - 6 Feb 2020

Looks good now.

avatar rdeutz rdeutz - close - 6 Feb 2020
avatar rdeutz rdeutz - merge - 6 Feb 2020
avatar rdeutz rdeutz - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 22:59:11
Closed_By rdeutz
avatar brianteeman
brianteeman - comment - 6 Feb 2020

thanks everyone

Add a Comment

Login with GitHub to post a comment