[#27818] - [4.0 dev] mobile button visible on desktop
- Fixed in Code Base
- 6 Feb 2020
- Medium
- Build: 4.0-dev
- # 27818
- Diff
- ravisaxena23:4.0-dev
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27805
Summary of Changes
Changes in SCSS as suggested by @infograf768 @brianteeman
Testing Instructions
Check on any browser
Expected result
mobile button should not be visible on desktop. gear button should not hide modals/alerts.
Actual result
mobile button not visible on desktop
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
@ravisaxena23 In your description, the expected result and the actual result are the same text. This can't be. Expected result should describe what you expect and how it will be when this PR will be applied, and actual result shall descibe how it is now in J4 without your PR.
@ravisaxena23 In your description, the expected result and the actual result are the same text. This can't be. Expected result should describe what you expect and how it will be when this PR will be applied, and actual result shall descibe how it is now in J4 without your PR.
I will remember it
Unfortunately this breaks the toggle at the bottom of the screen.
It should look like this
but with this PR it looks like this
This is due to z-index I will fix it. I have a question why this blue bar not come on my laptop what I'm doing is wrong.?
The only solution I see is
- Use again
$zindex-mobile-toggleinstead of$zindex-alerts - Modify the variable for
$zindex-alertsas it should always be on top of everything.
we have now
$zindex-alerts: 1030;
I would do
$zindex-alerts: 10000; // or more
in /administrator/templates/atum/scss/_variables.scss
| Labels |
Added:
?
|
||
Looks OK now. Weird as it looks like the Alert and the Gear are on the same z-index...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27818.
Looks OK now. Weird as it looks like the Alert and the Gear are on the same z-index...
$zindex-mobile-toggle: 9999; which is present in burger button while gear button hass z index=$zindex-alerts: 1030;
gear has same z-index than alert, but it works fine. I was not speaking of the burger
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27818.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27818.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 18:24:12 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
tks
Unfortunately this breaks the toggle at the bottom of the screen.
It should look like this
but with this PR it looks like this
