? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
5 Feb 2020

As you can see the folder name has a typo - this PR fixes that typo AND fixes the reference in the code so the typo doesn't have to bubble down

avatar brianteeman brianteeman - open - 5 Feb 2020
avatar brianteeman brianteeman - change - 5 Feb 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2020
Category Administration JavaScript Repository NPM Change
avatar richard67 richard67 - test_item - 5 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 5 Feb 2020

I have tested this item successfully on 4c08695

Code review:

  1. The change done by this PR here is consistent.
  2. The typo doesn't occur anywhere else.

Strange that nobody has seen that before (including me) ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27811.

avatar brianteeman
brianteeman - comment - 5 Feb 2020

Drone error is the usual fault image test and not related to this pr

avatar richard67
richard67 - comment - 5 Feb 2020

Yes, can confirm that.

avatar blueforce blueforce - test_item - 5 Feb 2020 - Tested successfully
avatar blueforce
blueforce - comment - 5 Feb 2020

I have tested this item successfully on 4c08695


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27811.

avatar Quy Quy - change - 5 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27811.

avatar rdeutz rdeutz - change - 5 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-05 17:44:18
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 5 Feb 2020
avatar rdeutz rdeutz - merge - 5 Feb 2020
avatar brianteeman
brianteeman - comment - 5 Feb 2020

Thanks Robert

Add a Comment

Login with GitHub to post a comment