[#2780] - Fix for (sub)menu with start level > 2 and actual == root
- Closed
- 28 Feb 2015
- Medium
- Build: staging
- # 2780
- Diff
- Iazel:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If I've understood the code well $item->tree contains all the item's parents, plus itself.
My use of case: I want to display all child of the active menu with depth's level 4 (legacy code, don't ask me why so deep...)
In my case, $path is the active menu's tree and is a root menu, so $path contains only itself.
I think this condition check !in_array($item->tree[$start - 2], $path) isn't correct, because if the level I want for my submenu is greater than 2 (4) and the current active menu is its root, it will still unset the item, because $item->tree[$start - 2] (direct son of the root) will not be in $path!
I think this patch is a more correct version and I've already tested it and seems to work well, but I don't know if can cause other bugs with other use cases.
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
Sorry but I don't think I'll do it. This is a more than one year old fix, I've completely forgotten the issue and how to reproduce it. Good luck
Closing
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-28 17:40:19 |
Could you please add a step-by-step testing procedure, including screen shots with arrows & annotations?
That way the issue + your patch will be easier to test.
Would you be so kind as to respond within 30 days, otherwise this issue will be closed.
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/2780.