[#27782] - [4.0] Unpublish admin modules from dashboard
- Fixed in Code Base
- 9 Feb 2020
- Medium
- Build: 4.0-dev
- # 27782
- Diff
- brianteeman:dashboard4
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
PR for #26652
Steps to reproduce the issue
Add a module to a dashboard on a position != cpanel.
Use chrome "well".
The module is rendered on the dashboard. And the cog for edit / unpublish appears.
Now click unpublish
Expected result
The module is unpublished
Actual result
Nothing happens
After PR
Module is unpublished as expected
Testing Notes
As this is a javascript change either npm i or node build.js compile-js are required after applying the patch
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27782.
I am afraid this only solves the issue when the module is displayed in dashboards.
Setting the module to position bottom also displays it all over backend.
Example:
Not only the cog and its dropdown is not displayed at should but the event is not attached to the unpublish.
@infograf768 You are right but this is another issue.
Adding in index.php
HTMLHelper::_('script', 'com_cpanel/admin-cpanel-default.min.js', array('version' => 'auto', 'relative' => true));
will solve the event but not the placement of the cog and its dropdown.
EDIT: cog and dropdown would in this case be solved by adding a class. Here for LTR
.module-actions {
position: absolute;
top: 0;
right: 0;
z-index: auto;
}
That is another issue. Please create a new issue for that
| Labels |
Added:
NPM Resource Changed
?
|
||
The appveyor error is nothing to do with this pr and is a general appveyor failure
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-09 16:54:31 |
| Closed_By | ⇒ | wilsonge |
Thanks!
pleasure
I have tested this item✅ successfully on 6f013c8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27782.