[#27773] - [4.0] Components dashboard
- Fixed in Code Base
- 16 Feb 2020
- Medium
- Build: 4.0-dev
- # 27773
- Diff
- brianteeman:dashboards
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
PR for #27770
Before this PR In the dashboards of joomla 4 we have a situation where sometimes there is an icon and sometimes not.
For all the static preset dashboards the icon was coded in the preset
For the dynamic dashboard for components there was no icon
With this PR then the components module will display icons now. For core components this is done by updating rhe menu table.
Any extension that already defines an icon eg com_pathctester will also work as this is fully backwards compatible
Extension developers can still add either an image or an icon via their components xml
eg
<menu img="class:icon_name">COM_MYCOMPONENT</menu> or
<menu img="pathto/image_name">COM_MYCOMPONENT</menu> or
<menu img="image:pathto/image_name">COM_MYCOMPONENT</menu>
This is a DRAFT. It is ready for testing but I haven't done the install sql or updated the core component xml yet until after feedback.
Documentation Changes Required
Hopefully none as the menu aspect of the xml should already be documented
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Modules |
| Status | New | ⇒ | Pending |
I guess the hardcoded stuff in the menu code can then be removed as well?
Actually not as those components do not have an entry in the _menus table
Aww, crap. That's true.
Maybe taking it from the menu preset could work? As I understood those presets there is one for the menu and then several for the dashboards. But I may be wrong, I still don't understand those presets.
Let's tackle one thing at a time ;)
If you could be so kind as to test what I have done so far then I can finish it
- sql installs
- postgresql updates
- component xml (not used but would be good to be consistent)
Note one thing about my implementation is that it does allow for dashboards to be created when using the alternate template as it uses the same field and formatting for the icon/image (assuming someone creates the dashboard code.
There were many ways to achieve this but I really tried for the most compatible method - not necessarily the cleverest.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27773.
I even tried adding img="class:comment" to my component menu declaration and it now shows an icon for it in the "Components Dashboard".
So that imho is a great solution which also works for 3rd parties.
| Category | SQL Administration com_admin Modules | ⇒ | SQL Administration com_admin Postgresql Modules |
| Labels |
Added:
?
|
||
| Category | SQL Administration com_admin Modules Postgresql | ⇒ | SQL Administration com_admin Postgresql com_associations com_banners com_contact com_finder com_newsfeeds Modules |
| Category | SQL Administration com_admin Modules Postgresql com_associations com_banners com_contact com_finder com_newsfeeds | ⇒ | SQL Administration com_admin Postgresql com_associations com_banners com_contact com_finder com_newsfeeds Modules Installation |
No longer a draft and ready for testing
Just noticed that News Feeds doesn't show the RSS icon you specified. I guess that is no longer (?) part of our FA package?
Or I did something wrong with all the composer/npm stuff
seems ok to me
https://fontawesome.com/icons/rss?style=solid
It may well be that I messed up something in my local installation. If it shows for you and others, then it's fine.
Could you post a screenshot of the resulting modification? For example concerning Multilingual Associations.
I am not aware of any way this impacts on multi lingual associations. But try it and see.
It impacts it by adding an icon in the dashboard.
For testers to know what to expect here is a screenshot after patch where the icons are present next to each component title.
conflicts
It's not an impact it is the desired and intended behaviour as described in the pull request
Cool down. By impact, i meant modify and it looks good. (I am not British).
conflicts remain to be solved.
conflicts resolved
@brianteeman I wanted to test your last changes again, and got a very messed up page. To verify it's not on my end, I've did a complet fresh installation and it was still the same. So probably a wrong conflict solving. Can you check if that's the same for you?
"News Feeds" is still not showing the icon - don't know what's wrong here and why it's showing for you and JM (according to his screenshot).
Indeed, with this PR you're reverting some of the changes you did there. Eg the <div class="module-wrapper"> is removed again. Probably other changes as well. You need to check that layout again.
It breaks the layout in my case:
After patch
Still display issue on a new installation.
Still doesn't look right to me.
Have a look at administrator/modules/mod_submenu/tmpl/default.php. If I remember right, you only changed the lines regarding the icon, but now there is a whole bunch of lines changed in the PR.
Still looks like a bad merge conflict solving.
Sorry for the bad merge conflict - now I really am sure it is correct
I have tested this item
Works perfectly fine again!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27773.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27773.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27773.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-16 12:15:31 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
thx
Looks like a good approach to me.
I guess the hardcoded stuff in the menu code can then be removed as well?