[#27772] - [4.0] I deleted a line that I don't think we need.
- Fixed in Code Base
- 5 Feb 2020
- Medium
- Build: 4.0-dev
- # 27772
- Diff
- astridx:cscontactdefault
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
I deleted a line that I don't think we need.
Testing Instructions
Code review
or create a contact and check the default view in front end.
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | New | ⇒ | Pending |
Should this be fixed in J3 (staging) ald later be merged up into 4.0-dev?
A bug in 3.x should be fixed in 3.x and merged to 4.0. You don't fix known 3.x bugs only in 4.0 without good reason.
A bug in 3.x should be fixed in 3.x and merged to 4.0. You don't fix known 3.x bugs only in 4.0 without good reason.
That's why I've asked. Not on me to decide though because it's not my PR.
If the project's support stance is not "bugs should be fixed in the lowest supported version applicable" then the project's support stance is FUBAR.
The project should not be incentivizing use of J4 by saying "oh, by the way, we fixed a bunch of bugs in 3.x in 4.0 without backporting those fixes even though we totally could".
I have tested this item
Tested in Feb 4, 2020 Nightly build and PHP 7.4.2 on localhost using Wampserver
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27772.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-05 15:08:40 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
@astridx Your PR seems to be correct, I can't see that variable being used somewhere. But in J3 we have the same in file
components/com_contact/views/contact/tmpl/default.php, line 14. Question is: Should this be fixed in J3 (staging) ald later be merged up into 4.0-dev? @wilsonge What do you suggest?