? ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar astridx
astridx
31 Jan 2020

Pull Request for Issue # #27735 .

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2020
Category Front End Plugins
avatar astridx astridx - open - 31 Jan 2020
avatar astridx astridx - change - 31 Jan 2020
Status New Pending
avatar astridx astridx - change - 1 Feb 2020
Title
remove hide default
[4.0] Remove hide default
avatar astridx astridx - edited - 1 Feb 2020
avatar SharkyKZ SharkyKZ - test_item - 1 Feb 2020 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 1 Feb 2020

I have tested this item successfully on 6c10ff6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27746.

avatar richard67
richard67 - comment - 1 Feb 2020

@astridx @SharkyKZ How shall this be tested? Code review? If real test: Please provide instructions.

avatar SharkyKZ
SharkyKZ - comment - 1 Feb 2020

@richard67 Code review. Check that the attribute is not used by Joomla\CMS\Form\Field\MediaField.

avatar Quy Quy - test_item - 2 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 2 Feb 2020

I have tested this item successfully on 6c10ff6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27746.

avatar Quy Quy - change - 2 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27746.

avatar richard67
richard67 - comment - 2 Feb 2020

Ah, I had tested it, too, and just had forgotten to set test result. Was successful.

avatar rdeutz
rdeutz - comment - 2 Feb 2020

After the change the code doesn't makes sense, can be removed entirely

avatar richard67
richard67 - comment - 2 Feb 2020

@rdeutz Good catch ... haven't noticed that before, but yes, except of the different name the child class does nothing different to the parent now.

avatar richard67
richard67 - comment - 2 Feb 2020

@rdeutz Adding back RTC was not me, I just commented on GH.

avatar richard67
richard67 - comment - 2 Feb 2020

Wait, I'll remove it again.

avatar richard67 richard67 - change - 2 Feb 2020
Status Ready to Commit Pending
Labels Added: ?
avatar rdeutz
rdeutz - comment - 2 Feb 2020

@astridx can you remove the entire function, please

avatar astridx
astridx - comment - 2 Feb 2020

@rdeutz After the change the code doesn't makes sense, can be removed entirely

You are right. Done

avatar richard67
richard67 - comment - 2 Feb 2020

@rdeutz Should the now empty child class be marked as deprecated so it can be removed in J5 in favour of using the base class instead?

avatar rdeutz
rdeutz - comment - 2 Feb 2020

No the pluging class needs to be there to be an active pluging

avatar richard67
richard67 - comment - 2 Feb 2020

I see. Thanks for clarification.

avatar richard67
richard67 - comment - 2 Feb 2020

@rdeutz I think it needs to change status in the tracker for setting RTC. Shall I do that?

avatar rdeutz rdeutz - change - 2 Feb 2020
Status Pending Ready to Commit
avatar rdeutz
rdeutz - comment - 2 Feb 2020

@richard67 I did already, falling into this always

avatar rdeutz rdeutz - change - 2 Feb 2020
Labels Added: ?
avatar rdeutz rdeutz - close - 2 Feb 2020
avatar rdeutz rdeutz - merge - 2 Feb 2020
avatar rdeutz rdeutz - change - 2 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-02 17:45:39
Closed_By rdeutz

Add a Comment

Login with GitHub to post a comment