? ? Pending

User tests: Successful: 2 chmst, richard67 Unsuccessful: 0

avatar svenbluege
svenbluege
31 Jan 2020

…x for the similar tags module: 0416160

Pull Request for Issue #27744

Summary of Changes

Allow displaying items with core_access=0 from _ucm_content in the Popular Tags module. The zero value is the result if a component does not use an access column.

Testing Instructions

  • create the popular tags module
  • create an article
  • create a content tag
  • assign that tag to the article
  • change the core_access value for the article representation in _ucm_content to 0

Expected result

I see my tag in the popular tags module.

Actual result

I don't see my tag in the popular tags module.

Documentation Changes Required

No.

avatar svenbluege svenbluege - open - 31 Jan 2020
avatar svenbluege svenbluege - change - 31 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2020
Category Modules Front End
avatar svenbluege svenbluege - change - 2 Feb 2020
Labels Added: ?
avatar richard67
richard67 - comment - 2 Feb 2020

Will test later today.

avatar richard67 richard67 - test_item - 2 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 2 Feb 2020

I have tested this item successfully on 99ce3c3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27745.

avatar chmst chmst - test_item - 2 Feb 2020 - Tested successfully
avatar chmst
chmst - comment - 2 Feb 2020

I have tested this item successfully on 99ce3c3

The PR works as described, therefore the test is successful.
But a question: When is core_access set to 0?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27745.

avatar richard67
richard67 - comment - 2 Feb 2020

@chmst Is explained in the issue #27744 . There may be 3rd party components using an own acl handling and not the core one. We already have the same change as done here in the similar tags module, was once made by @Bakual . So it is ok.

avatar SharkyKZ SharkyKZ - change - 5 Feb 2020
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 5 Feb 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27745.

avatar rdeutz rdeutz - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 08:07:18
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 6 Feb 2020
avatar rdeutz rdeutz - merge - 6 Feb 2020

Add a Comment

Login with GitHub to post a comment