? NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jan 2020

In a previous pull request I added code which adds a caption to every table AND indicates how the table is sorted. This is only visible to screen readers

To improve this further we should also include how the table is filtered.

This DRAFT pr which I hope the javascript gurus can help with adds the filtered information.

I have only enabled this for the table of contacts at this time while in draft

Currently the output is like this

<caption id="captionTable" class="sr-only">
Table of Contacts
<span id="orderedBy">Sorted by:Title - descending</span>
<span id="filteredBy">Filtered by:Public3</span>
</caption>

As you can see the filtered by is displaying just the selected value of the selected filters, which is kind of ok when its text but is meaningless when it is a number.

Ideally it would say
Filtered by: Access level = Public, Max Levels =3

(as this is javascript it will require eithernpm i or node build.js --compile-js to test it)

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2020
Category Administration com_contact Language & Strings JavaScript Repository NPM Change
avatar brianteeman brianteeman - open - 31 Jan 2020
avatar brianteeman brianteeman - change - 31 Jan 2020
Status New Pending
avatar brianteeman brianteeman - change - 31 Jan 2020
The description was changed
avatar brianteeman brianteeman - edited - 31 Jan 2020
fee6b7d 31 Jan 2020 avatar brianteeman cs
avatar brianteeman brianteeman - change - 31 Jan 2020
Labels Added: ? NPM Resource Changed ? ?
avatar angieradtke
angieradtke - comment - 26 Feb 2020

that makes sense .-)

avatar jwaisner jwaisner - change - 6 Mar 2020
Priority Medium Low
avatar brianteeman
brianteeman - comment - 11 Mar 2020

Maybe someone can convince the accessibility team to test this

avatar angieradtke
angieradtke - comment - 11 Mar 2020

Christiane helped Stefan. He knows what do do - still waiting for results (1 week).

avatar brianteeman
brianteeman - comment - 7 Apr 2020

Closed - let the accessibility team fix it

avatar brianteeman brianteeman - change - 7 Apr 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-04-07 16:55:48
Closed_By brianteeman
Labels Added: ?
Removed: ?
avatar brianteeman brianteeman - close - 7 Apr 2020
avatar wilsonge
wilsonge - comment - 8 May 2020

https://github.com/joomla/joomla-cms/compare/4.0-dev...wilsonge:feature/filtered-items-a11y?expand=1

Javascript here for you hopefully. It's enough to work - although as the labels seem weird right now the text could be improved. But hopefully that's enough for someone to run with

avatar brianteeman
brianteeman - comment - 8 May 2020

Thanks. Will check it out over the weekend

Add a Comment

Login with GitHub to post a comment