[#27733] - [4.0] Password toggler markup and styling
- Fixed in Code Base
- 5 Feb 2020
- Medium
- Build: 4.0-dev
- # 27733
- Diff
- SharkyKZ:j4/password-view
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24312.
Summary of Changes
Corrects password toggler markup and styling to have a visible focus outline.
Converts to FA icons, adds fa-fw class to keep same width when toggling.
Testing Instructions
Run node build.js --compile-js.
Go to a form with password field.
Inspect styling.
Click on toggle button a few times.
Check that the icon and the screenreader text changes correctly.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration JavaScript Repository NPM Change Layout Front End |
| Labels |
Added:
NPM Resource Changed
?
|
||
The width issue is resolved by this
BUT (sorry there is always a but)
The hover/active (?) colour is now different - almost black
before
after
That's just how btn-secondary is styled in Atum. There's still the width issue, icon is clearly off-center.
So why did you change it to that button. It's not consistent with similar functions
To use them same class everywhere.
My apologies - we are actually using a mix already :(
The first is btn-primary and the second btn-secondary
| Category | Modules Administration JavaScript Repository NPM Change Layout Front End | ⇒ | Administration com_postinstall Modules Templates (admin) JavaScript Repository NPM Change Layout Front End |
Was it intentional to change the styling on the front end login module?
Before
After
Yes, the button is now styled like a button.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27733.
Eye is not centered so there is a slight shift when toggling between icons.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27733.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27733.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-05 17:53:06 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
it was pointed out to me before that the code should not be dependant on using fontawesome especially for the frontend