? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
31 Jan 2020

Summary of Changes

Following up on #27684 (comment)
custom-select should be auto instead of 100%

Testing Instructions

Display Global Configuration Text Filters tab. Reduce window width.
See before patch. Patch and use npm

Before patch

beforeconfig

After patch

afterconfig

avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2020
Category Administration Templates (admin)
avatar infograf768 infograf768 - open - 31 Jan 2020
avatar infograf768 infograf768 - change - 31 Jan 2020
Status New Pending
avatar infograf768 infograf768 - change - 31 Jan 2020
Labels Added: ?
avatar brianteeman brianteeman - test_item - 31 Jan 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 31 Jan 2020

I dont get the scroll bar on my phone or on chrome mobile emulation on my desktop - but maybe thats an OS thing as its not unique to this screen


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27731.

avatar brianteeman
brianteeman - comment - 31 Jan 2020

I have tested this item successfully on 2efd2ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27731.

avatar Quy Quy - test_item - 31 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 31 Jan 2020

I have tested this item successfully on 2efd2ee


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27731.

avatar Quy Quy - change - 31 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27731.

avatar Quy Quy - change - 31 Jan 2020
Labels Added: ?
avatar Quy Quy - change - 31 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-31 14:32:16
Closed_By Quy
avatar Quy Quy - close - 31 Jan 2020
avatar Quy Quy - merge - 31 Jan 2020
avatar Quy
Quy - comment - 31 Jan 2020

@infograf768 Table not full width.

27731

avatar infograf768
infograf768 - comment - 31 Jan 2020

@infograf768 Table not full width.

will look tomorrow.

avatar infograf768
infograf768 - comment - 1 Feb 2020

@Quy
Indeed, table is not full width in very wide screens because was added the class table-responsive in #27684
which was the only way to solve the display in mobile view.

We could solve the issue using @media queries, but we have a problem with the sidebar menu which can be toggled and therefore change drastically the width.
maybe this could be solved by js to only depend on the parent element.

@ciar4n
Can you look at this?

avatar ciar4n
ciar4n - comment - 1 Feb 2020

The table-responsive class would set the display to block which will not play nice with 100% width tables. If possible try applying the table-responsive class to a parent div of the table, not the table itself.

<div class="table-responsive">
  <table class="table"> .. </table>
</div> 
avatar infograf768
infograf768 - comment - 1 Feb 2020

will try now

avatar infograf768
infograf768 - comment - 1 Feb 2020

Works great.
Please test
#27754

Add a Comment

Login with GitHub to post a comment