? ? ? Pending
Pull Request for # 27717

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
30 Jan 2020

Pull Request for Issue #27717.

Summary of Changes

Corrects error message when uploading too large files in com_media.

Testing Instructions

  1. Try to upload files larger than your system allows.
  2. Try to upload unsafe files (e.g. PHP files).
  3. Try to upload small and safe files (e.g. images).

Expected result

  1. Upload fails with message: Total size of upload exceeds the limit.
  2. Upload fails with message: You have tried to upload file(s) that are not safe.
  3. File is uploaded successfully.

Actual result

  1. Upload fails with message: You have tried to upload file(s) that are not safe.
  2. Upload fails with message: You have tried to upload file(s) that are not safe.
  3. File is uploaded successfully.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 30 Jan 2020
avatar SharkyKZ SharkyKZ - change - 30 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2020
Category Administration com_media Language & Strings
avatar SharkyKZ SharkyKZ - change - 30 Jan 2020
Rel_Number 27717
Relation Type Pull Request for
Labels Added: ?
avatar richard67
richard67 - comment - 30 Jan 2020

@SharkyKZ With this PR applied and trying to upload a PHP file I get "Please input a file to upload." and not "You have tried to upload file(s) that are not safe." liike your instructions say. Before applying your PR it was like descibed in your instructions.

6be74f9 31 Jan 2020 avatar SharkyKZ Typo
avatar SharkyKZ SharkyKZ - change - 31 Jan 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jan 2020
Category Administration com_media Language & Strings Administration com_media Language & Strings Libraries
avatar SharkyKZ
SharkyKZ - comment - 31 Jan 2020

@richard67 Should work now.

avatar richard67 richard67 - test_item - 1 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 1 Feb 2020

I have tested this item successfully on 1c9e337


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27730.

avatar alikon alikon - test_item - 2 Feb 2020 - Tested successfully
avatar alikon
alikon - comment - 2 Feb 2020

I have tested this item successfully on 1c9e337


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27730.

avatar alikon alikon - change - 2 Feb 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27730.

avatar rdeutz rdeutz - change - 2 Feb 2020
Labels Added: ?
avatar rdeutz rdeutz - change - 3 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-03 14:45:05
Closed_By rdeutz
avatar rdeutz rdeutz - close - 3 Feb 2020
avatar rdeutz rdeutz - merge - 3 Feb 2020

Add a Comment

Login with GitHub to post a comment