? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
29 Jan 2020

Summary of Changes

Fixes routing not working in com_wrapper.

Testing Instructions

Create Wrapper -> Iframe Wrapper menu item.
Inspect its link in menu module.

Expected result

Link with just menu alias, e.g. wrapper-item.

Actual result

Link like this: wrapper-item?view=wrapper.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 29 Jan 2020
avatar SharkyKZ SharkyKZ - change - 29 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2020
Category Administration Front End com_wrapper
cbaabcf 29 Jan 2020 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 29 Jan 2020
Labels Added: ?
avatar astridx
astridx - comment - 23 Feb 2020

I have tested this Patch successful.

  1. git fetch origin pull/27702/head:j4/wrapper-router

  2. git checkout j4/wrapper-router

  3. No new install or npm ci is needed.

  4. I created a menu item of type wrapper
    Menus  New Item   admin   Administration

  5. Without the patch the URL
    http://localhost/joomla-cms4/index.php/wrapper?view=wrapper
    is used when I click on the menu item in front end.
    With the path the used URL is
    http://localhost/joomla-cms4/index.php/wrapper
    I tested with the current ‎4.0.0-beta1-dev on Ubuntu with PHP 7.2 and MySQL 5.7.

avatar astridx
astridx - comment - 23 Feb 2020

I have tested this item successfully on 2ebef57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27702.

avatar astridx astridx - test_item - 23 Feb 2020 - Tested successfully
avatar astridx astridx - test_item - 23 Feb 2020 - Tested successfully
avatar astridx astridx - test_item - 23 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 26 Feb 2020

I have tested this item successfully on 2ebef57


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27702.

avatar jwaisner jwaisner - test_item - 26 Feb 2020 - Tested successfully
avatar jwaisner jwaisner - change - 26 Feb 2020
Status Pending Ready to Commit
avatar jwaisner
jwaisner - comment - 26 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27702.

avatar wilsonge wilsonge - change - 3 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-03 11:02:58
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 3 Mar 2020

Thanks!

Add a Comment

Login with GitHub to post a comment