? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
29 Jan 2020

Summary of Changes

As part of query cleanup in I moved all unconditionally selected columns to list.select state property's default value. This improves performance when using custom list.select values (e.g. in modules) by not selecting unneeded columns but can also cause a small break in case those columns are expected to be selected anyways.

This reverts that for now.

Testing Instructions

Code review.
Or view banners, banner clients, content languages, menu items, newsfeeds and template styles in backend.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 29 Jan 2020
avatar SharkyKZ SharkyKZ - change - 29 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2020
Category Administration com_banners com_languages com_menus com_newsfeeds com_templates
avatar Quy Quy - test_item - 5 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 5 Feb 2020

I have tested this item successfully on b2730d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27701.

avatar jwaisner jwaisner - test_item - 5 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Feb 2020

I have tested this item successfully on b2730d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27701.

avatar SharkyKZ SharkyKZ - change - 5 Feb 2020
Status Pending Ready to Commit
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 5 Feb 2020

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27701.

avatar rdeutz rdeutz - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 10:05:07
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 6 Feb 2020
avatar rdeutz rdeutz - merge - 6 Feb 2020

Add a Comment

Login with GitHub to post a comment