? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
27 Jan 2020

Pull Request for Issue #27615 (comment) .

Summary of Changes

Show the columns in the permissions table below each other.

Testing Instructions

  1. Apply this patch and run npm ci.
  2. Open permissions on a small display.

My changes

Contacts  Options   test   Administration

Actual result

Contacts  Options   test   Administration(1)

Documentation Changes Required

cf85193 26 Jan 2020 avatar astridx wip
b131ad2 27 Jan 2020 avatar astridx cs
avatar astridx astridx - open - 27 Jan 2020
avatar astridx astridx - change - 27 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2020
Category Administration Templates (admin) Layout
3859daa 27 Jan 2020 avatar astridx cs
avatar astridx astridx - change - 27 Jan 2020
Labels Added: ?
70c4e86 27 Jan 2020 avatar astridx cs
b8b1839 27 Jan 2020 avatar astridx wip
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2020
Category Administration Templates (admin) Layout Administration Templates (admin) Front End Layout
avatar astridx
astridx - comment - 27 Jan 2020

@C-Lodder Thank you.
Please see if it's OK now.

74947c0 27 Jan 2020 avatar astridx wip
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jan 2020
Category Administration Templates (admin) Layout Front End Administration Templates (admin) Layout
avatar infograf768
infograf768 - comment - 30 Jan 2020

This needs some more changes for RTL
Screen Shot 2020-01-30 at 12 10 46

2f9acb7 14 Feb 2020 avatar astridx align
24cca66 14 Feb 2020 avatar astridx cs
avatar astridx
astridx - comment - 14 Feb 2020

Thanks to everyone who gave me tips. I have improved. This can now be tested again.
Is the <sup>2</sup> an error in the language file?
For me it looks like this:

تنظیمات کلی   admin   مدیریت

avatar infograf768
infograf768 - comment - 16 Feb 2020

Is the <sup>2</sup> an error in the language file?

Yep, it is.

avatar infograf768
infograf768 - comment - 16 Feb 2020

I suggest some small modifications for joomla-tab.scss in order to be normalized compared to other scss.

    #permissions-sliders {
      section[active] {
        padding: 0 !important;

        @include media-breakpoint-down(md) {
          .respTable {
            [dir=ltr] & {
              text-align: right;
            }

            [dir=rtl] & {
              text-align: left;
            }
          }

          .respTable, .respTable thead, .respTable tbody, .respTable tr, .respTable th, .respTable td {
            display: block;
          }

          .respTable thead {
            position: absolute;
            top: -1111px;
            left: -1111px;
          }

          .respTable td::before {
            content: attr(data-label) ":";
            font-weight: $bold-weight;

            [dir=ltr] & {
              float: left;
              padding: 0 2em 0 0;
            }

            [dir=rtl] & {
              float: right;
              padding: 0 0 0 2em;
            }
          }

          .respTable td:nth-child(1) {
            font-weight: $bold-weight;
          }

          .respTable td:last-child {
            border-bottom: 1em var(--atum-bg-dark-80) solid;
          }

          .oddCol {
            background: var(--atum-bg-light);
          }
        }
      }
    }
  }
}
avatar astridx
astridx - comment - 16 Feb 2020

@infograf768 I have changed it. I hope I've seen everything.

avatar infograf768
infograf768 - comment - 16 Feb 2020

looks ok, will test tomorrow. :)

avatar infograf768 infograf768 - test_item - 17 Feb 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Feb 2020

I have tested this item successfully on f41a4a0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27670.

avatar N6REJ N6REJ - test_item - 17 Feb 2020 - Tested successfully
avatar N6REJ
N6REJ - comment - 17 Feb 2020

I have tested this item successfully on f41a4a0

works via pt 4 ( ci on )


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27670.

pt4

avatar alikon alikon - change - 17 Feb 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27670.

avatar infograf768 infograf768 - change - 18 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-18 06:22:45
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 18 Feb 2020
avatar infograf768 infograf768 - merge - 18 Feb 2020
avatar infograf768
infograf768 - comment - 18 Feb 2020

Thanks.

Add a Comment

Login with GitHub to post a comment