NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Jan 2020

the class media-view-icons should only be declared once in the scss file.

this is just a change for maintainability as the compiled css file that is generated is identical before and after this pr

the minified file can be located media\com_media\css\mediamanager.min.css

avatar brianteeman brianteeman - open - 26 Jan 2020
avatar brianteeman brianteeman - change - 26 Jan 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2020
Category Administration com_media NPM Change
avatar jwaisner
jwaisner - comment - 26 Jan 2020

@brianteeman Can you advise if this is a code review or if testing is needed?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27669.

avatar brianteeman
brianteeman - comment - 26 Jan 2020

if i was testing it I would apply the pr and ensure that the compiled css was identical to the compiled css before the pr

avatar brianteeman brianteeman - change - 27 Jan 2020
Labels Added: NPM Resource Changed ?
avatar Quy Quy - test_item - 4 Feb 2020 - Tested successfully
avatar Quy
Quy - comment - 4 Feb 2020

I have tested this item successfully on fc866db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27669.

avatar astridx
astridx - comment - 6 Feb 2020

I have tested this PR successful.

I run

  1. git fetch origin pull/27669/head:scss1
  2. git checkout scss1
  3. npm ci

The compiled CSS was identical and the icons looked the same - before and after

Media   test   Administration

avatar astridx astridx - test_item - 6 Feb 2020 - Tested successfully
avatar astridx
astridx - comment - 6 Feb 2020

I have tested this item successfully on fc866db


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27669.

avatar Quy Quy - change - 6 Feb 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27669.

avatar rdeutz rdeutz - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 12:22:02
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 6 Feb 2020
avatar rdeutz rdeutz - merge - 6 Feb 2020
avatar brianteeman
brianteeman - comment - 6 Feb 2020

thanks

Add a Comment

Login with GitHub to post a comment