User tests: Successful: Unsuccessful:
the class media-view-icons should only be declared once in the scss file.
this is just a change for maintainability as the compiled css file that is generated is identical before and after this pr
the minified file can be located media\com_media\css\mediamanager.min.css
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media NPM Change |
if i was testing it I would apply the pr and ensure that the compiled css was identical to the compiled css before the pr
Labels |
Added:
NPM Resource Changed
?
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 12:22:02 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
thanks
@brianteeman Can you advise if this is a code review or if testing is needed?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27669.